Commit 36b1927
authored
feat: Support RIGHT/FULL joins in NLJ memory-limited execution (#21833)
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases.
You can link an issue to this PR using the GitHub syntax. For example
`Closes #123` indicates that this PR will close issue #123.
-->
- Closes #.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly
in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand
your changes and offer better suggestions for fixes.
-->
## What changes are included in this PR?
Previously RIGHT/FULL/RIGHT SEMI/RIGHT ANTI/RIGHT MARK joins were
excluded from the memory-limited (multi-pass) fallback path because they
need to track which right rows have been matched across all left chunks.
They would OOM instead of spilling.
Now all join types support the fallback:
- A global right bitmap (Vec<BooleanBuffer>, indexed by right batch
sequence number) accumulates matches across all left chunk passes.
ReplayableStreamSource guarantees consistent batch boundaries across
passes, so batch sequence numbers are stable.
- In memory-limited mode, EmitRightUnmatched merges the current batch's
bitmap into the global accumulator (bitwise OR) instead of emitting
unmatched rows immediately.
- After the last left chunk, a new state EmitGlobalRightUnmatched
replays the right side one more time and uses the accumulated bitmap to
emit unmatched right rows correctly.
Single-pass behavior is unchanged: the global bitmap path is only active
when is_memory_limited() is true.
Co-authored-by: Claude Code
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example,
are they covered by existing tests)?
-->
Unit tests and e2e tests
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
No1 parent c134a84 commit 36b1927
2 files changed
Lines changed: 477 additions & 57 deletions
File tree
- datafusion
- physical-plan/src/joins
- sqllogictest/test_files
0 commit comments