fix generate_series table function overflows

Author: xiedeyantu

datafusion/functions-table/src/generate_series.rs

@@ -98,7 +98,11 @@ impl SeriesValue for i64 {
     }
 
     fn advance(&mut self, step: &Self::StepType) -> Result<()> {
-        *self += step;
+        *self = self.checked_add(*step).ok_or_else(|| {
+            datafusion_common::DataFusionError::Execution(
+                "generate_series: integer overflow while advancing series".to_string(),
+            )
+        })?;
         Ok(())
     }
 

datafusion/sqllogictest/test_files/table_functions.slt

@@ -183,6 +183,11 @@ SELECT * FROM generate_series(1, 2, 3, 4)
 statement error DataFusion error: Error during planning: Argument \#1 must be an INTEGER, TIMESTAMP, DATE or NULL, got Utf8
 SELECT * FROM generate_series('foo', 'bar')
 
+# Regression test: generate_series with a step that would advance past i64::MAX must
+# return an execution error rather than panicking (overflow in integer iterator).
+statement error DataFusion error: Execution error: generate_series: integer overflow while advancing series
+SELECT * FROM generate_series(9223372036854775806, 9223372036854775807, 2)
+
 # UDF and UDTF `generate_series` can be used simultaneously
 query ? rowsort
 SELECT generate_series(1, t1.end) FROM generate_series(3, 5) as t1(end)