wip

Author: jayshrivastava

datafusion/ffi/src/physical_expr/mod.rs

@@ -112,10 +112,6 @@ pub struct FFI_PhysicalExpr {
 
     pub fmt_sql: unsafe extern "C" fn(&Self) -> FFI_Result<SString>,
 
-    #[deprecated(
-        since = "54.0.0",
-        note = "downcast to `DynamicFilterPhysicalExpr` and call `current()` instead"
-    )]
     pub snapshot: unsafe extern "C" fn(&Self) -> FFI_Result<FFI_Option<FFI_PhysicalExpr>>,
 
     pub snapshot_generation: unsafe extern "C" fn(&Self) -> u64,
@@ -368,7 +364,6 @@ unsafe extern "C" fn fmt_sql_fn_wrapper(expr: &FFI_PhysicalExpr) -> FFI_Result<S
     FFI_Result::Ok(result.into())
 }
 
-#[allow(deprecated)]
 unsafe extern "C" fn snapshot_fn_wrapper(
     expr: &FFI_PhysicalExpr,
 ) -> FFI_Result<FFI_Option<FFI_PhysicalExpr>> {
@@ -432,7 +427,6 @@ unsafe extern "C" fn clone_fn_wrapper(expr: &FFI_PhysicalExpr) -> FFI_PhysicalEx
             propagate_statistics: propagate_statistics_fn_wrapper,
             get_properties: get_properties_fn_wrapper,
             fmt_sql: fmt_sql_fn_wrapper,
-            #[expect(deprecated)]
             snapshot: snapshot_fn_wrapper,
             snapshot_generation: snapshot_generation_fn_wrapper,
             is_volatile_node: is_volatile_node_fn_wrapper,
@@ -476,7 +470,6 @@ impl From<Arc<dyn PhysicalExpr>> for FFI_PhysicalExpr {
             propagate_statistics: propagate_statistics_fn_wrapper,
             get_properties: get_properties_fn_wrapper,
             fmt_sql: fmt_sql_fn_wrapper,
-            #[expect(deprecated)]
             snapshot: snapshot_fn_wrapper,
             snapshot_generation: snapshot_generation_fn_wrapper,
             is_volatile_node: is_volatile_node_fn_wrapper,
@@ -700,7 +693,6 @@ impl PhysicalExpr for ForeignPhysicalExpr {
 
     fn snapshot(&self) -> Result<Option<Arc<dyn PhysicalExpr>>> {
         unsafe {
-            #[allow(deprecated)]
             let result = df_result!((self.expr.snapshot)(&self.expr))?;
             Ok(result
                 .map(|expr| <Arc<dyn PhysicalExpr>>::from(&expr))
@@ -947,6 +939,7 @@ mod tests {
         assert_eq!(left, right);
     }
 
+    /// The snapshot API is deprecated.
     #[allow(deprecated)]
     #[test]
     fn ffi_physical_expr_snapshots() -> Result<(), DataFusionError> {

datafusion/physical-expr/src/expressions/dynamic_filters.rs

@@ -689,20 +689,6 @@ mod test {
         assert!(arr_1.eq(&expected));
     }
 
-    #[test]
-    fn test_current() {
-        let expr = lit(42) as Arc<dyn PhysicalExpr>;
-        let dynamic_filter = DynamicFilterPhysicalExpr::new(vec![], Arc::clone(&expr));
-
-        // Read the current expression.
-        assert_eq!(&dynamic_filter.current().unwrap(), &expr);
-
-        // Update the current expression.
-        let new_expr = lit(100) as Arc<dyn PhysicalExpr>;
-        dynamic_filter.update(Arc::clone(&new_expr)).unwrap();
-        assert_eq!(&dynamic_filter.current().unwrap(), &new_expr);
-    }
-
     #[allow(deprecated)]
     #[test]
     fn test_snapshot() {