Skip to content

Commit 4876cdc

Browse files
authored
refactor array_remove benchmarks & add nested benches (#21834)
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> N/A ## Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> Looking to push a PR on optimizing `array_remove` later; discovered we were lacking coverage for `array_remove_n` and `array_remove_all` variants, as well as nested types. In the process of adding them, decided to also do some cleanup of the benchmarks, specifically to generate data in a more targeted fashion suitable to what we're benchmarking in the functions (removing a specified needle from a haystack). ## What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> - Refactor functions used to create test data, unifying where possible - Remove f64, decimal & binary benchmarks - Add nested i64 (list<list<i64>>) benchmarks - Add remove_n & remove_all benchmarks for i64 and nested i64 ## Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> Benchmark only changes. ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> No. <!-- If there are any breaking changes to public APIs, please add the `api change` label. -->
1 parent 53bd344 commit 4876cdc

2 files changed

Lines changed: 397 additions & 404 deletions

File tree

0 commit comments

Comments
 (0)