Skip to content

Commit 4ca67b4

Browse files
authored
Apply suggestions from code review
Co-authored-by: Adrian Garcia Badaracco <1755071+adriangb@users.noreply.github.com>
1 parent 313a6df commit 4ca67b4

3 files changed

Lines changed: 4 additions & 17 deletions

File tree

datafusion/physical-expr/src/expressions/like.rs

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -347,12 +347,7 @@ mod test {
347347
}
348348
}
349349

350-
/// Tests for the `try_to_proto` / `try_from_proto` hooks (issue #22418).
351-
///
352-
/// These drive the encode/decode hooks directly with small stub
353-
/// encoder/decoders so every branch can be covered without depending on
354-
/// `datafusion-proto`: the happy path, the wrong-node and missing-child
355-
/// rejections, and child encode/decode error propagation.
350+
/// Tests for the `try_to_proto` / `try_from_proto` hooks.
356351
#[cfg(all(test, feature = "proto"))]
357352
mod proto_tests {
358353
use super::*;

datafusion/physical-expr/src/lib.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,7 @@ mod partitioning;
4040
mod physical_expr;
4141
pub mod planner;
4242
pub mod projection;
43-
/// Shared test helpers for the `try_to_proto` / `try_from_proto` migration
44-
/// (issue #22418). Compiled only under `cfg(test)` with the `proto` feature.
43+
/// Shared test helpers for the `try_to_proto` / `try_from_proto` unit tests
4544
#[cfg(all(test, feature = "proto"))]
4645
pub(crate) mod proto_test_util;
4746
mod scalar_function;

datafusion/physical-expr/src/proto_test_util.rs

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,8 @@
1515
// specific language governing permissions and limitations
1616
// under the License.
1717

18-
//! Shared test helpers for exercising the `try_to_proto` / `try_from_proto`
19-
//! hooks (issue #22418) without depending on `datafusion-proto`.
20-
//!
21-
//! As built-in expressions are ported off the central proto downcast chain,
22-
//! each one's unit tests need to drive the new encode/decode hooks in
23-
//! isolation. The generic scaffolding — stub encoder/decoders and a
24-
//! placeholder child-node builder — lives here so it is written once and
25-
//! reused across expressions. Expression-specific node builders and fixtures
26-
//! stay in each expression's own test module.
18+
//! Shared test helpers for proto serialization / deserialization in expression unit tests
19+
//! without depending on `datafusion-proto` (which would create circular deps).
2720
2821
use std::cell::Cell;
2922
use std::sync::Arc;

0 commit comments

Comments
 (0)