Skip to content

Commit 50b6bf8

Browse files
authored
fix: Run release verification with --profile=ci (#20987)
## Which issue does this PR close? - Related to #20689 - Closes #20992 - part of #19692 ## Rationale for this change While verifying DataFusion 53.0.0, we found that the `verify_release_candidate` script was not working correctly, as it was hitting an assertion Specifically: ```shell $ ./dev/release/verify-release-candidate.sh 53.0.0 2 ... joins::sort_merge_join::tests::test_should_emit_early_when_have_enough_data_to_emit test result: FAILED. 1190 passed; 78 failed; 0 ignored; 0 measured; 0 filtered out; finished in 8.89s error: test failed, to rerun pass `-p datafusion-physical-plan --lib` + cleanup + '[' no = yes ']' + echo 'Failed to verify release candidate. See /var/folders/1l/tg68jc6550gg8xqf1hr4mlwr0000gn/T/datafusion-53.0.0.XXXXX.d5aUZcsu7v for details.' Failed to verify release candidate. See /var/folders/1l/tg68jc6550gg8xqf1hr4mlwr0000gn/T/datafusion-53.0.0.XXXXX.d5aUZcsu7v for details. ``` The failure is due to an overzealous assert in arrow-rs (see apache/arrow-rs#9506) that will be fixed in the next release The reason this isn' triggered on CI is that sqllogictests are run with `--profile=ci` -- see https://github.com/apache/datafusion/blob/11b9693952cd419b73dd03cc39f22c8b343bc05c/.github/workflows/rust.yml#L299-L298 ## What changes are included in this PR? 1. Update verify_release.sh to use `--profile=ci` when running sqllogictests to mirror CI ## Are these changes tested? I tested it manually (STILLRUNNING) ```shell $ ./dev/release/verify-release-candidate.sh 53.0.0 2 ... /var/folders/1l/tg68jc6550gg8xqf1hr4mlwr0000gn/T/datafusion-53.0.0.XXXXX.j0FgM9yH5J + TEST_SUCCESS=yes + echo 'Release candidate looks good!' Release candidate looks good! + exit 0 + cleanup + '[' yes = yes ']' + rm -fr /var/folders/1l/tg68jc6550gg8xqf1hr4mlwr0000gn/T/datafusion-53.0.0.XXXXX.j0FgM9yH5J ``` ## Are there any user-facing changes? No
1 parent 84a79e1 commit 50b6bf8

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

dev/release/verify-release-candidate.sh

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
check_dependencies() {
2323
local missing_deps=0
2424
local required_deps=("curl" "git" "gpg" "cc" "protoc")
25-
25+
2626
# Either shasum or sha256sum/sha512sum are required
2727
local has_sha_tools=0
2828

@@ -32,7 +32,7 @@ check_dependencies() {
3232
missing_deps=1
3333
fi
3434
done
35-
35+
3636
# Check for either shasum or sha256sum/sha512sum
3737
if command -v shasum &> /dev/null; then
3838
has_sha_tools=1
@@ -42,7 +42,7 @@ check_dependencies() {
4242
echo "Error: Neither shasum nor sha256sum/sha512sum are installed or in PATH"
4343
missing_deps=1
4444
fi
45-
45+
4646
if [ $missing_deps -ne 0 ]; then
4747
echo "Please install missing dependencies and try again"
4848
exit 1
@@ -163,7 +163,7 @@ test_source_distribution() {
163163
git clone https://github.com/apache/parquet-testing.git parquet-testing
164164

165165
cargo build
166-
cargo test --all --features=avro
166+
cargo test --profile=ci --all --features=avro
167167

168168
if ( find -iname 'Cargo.toml' | xargs grep SNAPSHOT ); then
169169
echo "Cargo.toml version should not contain SNAPSHOT for releases"

0 commit comments

Comments
 (0)