fix

Author: xiedeyantu

datafusion/functions/src/math/factorial.rs

@@ -23,7 +23,8 @@ use arrow::datatypes::{DECIMAL256_MAX_PRECISION, DataType, Int64Type};
 use arrow_buffer::i256;
 
 use datafusion_common::{
-    DataFusionError, Result, ScalarValue, internal_err, utils::take_function_args,
+    DataFusionError, Result, ScalarValue, exec_err, internal_err,
+    utils::take_function_args,
 };
 use datafusion_expr::{
     ColumnarValue, Documentation, ScalarFunctionArgs, ScalarUDFImpl, Signature,
@@ -158,7 +159,7 @@ const FACTORIALS: [i64; 21] = [
 
 fn compute_factorial(n: i64) -> Result<i256> {
     if n < 0 {
-        return Ok(i256::from(1));
+        return exec_err!("factorial of a negative number is undefined");
     }
 
     if n < FACTORIALS.len() as i64 {
@@ -173,9 +174,7 @@ fn compute_factorial(n: i64) -> Result<i256> {
     }
 
     if result.to_string().len() > DECIMAL256_MAX_PRECISION as usize {
-        return Err(DataFusionError::Execution(format!(
-            "Overflow happened on FACTORIAL({n})"
-        )));
+        return exec_err!("Overflow happened on FACTORIAL({n})");
     }
 
     Ok(result)