deprecate

Author: jayshrivastava

datafusion/ffi/src/physical_expr/mod.rs

@@ -112,6 +112,10 @@ pub struct FFI_PhysicalExpr {
 
     pub fmt_sql: unsafe extern "C" fn(&Self) -> FFI_Result<SString>,
 
+    #[deprecated(
+        since = "54.0.0",
+        note = "downcast to `DynamicFilterPhysicalExpr` and call `current()` instead"
+    )]
     pub snapshot: unsafe extern "C" fn(&Self) -> FFI_Result<FFI_Option<FFI_PhysicalExpr>>,
 
     pub snapshot_generation: unsafe extern "C" fn(&Self) -> u64,
@@ -428,6 +432,7 @@ unsafe extern "C" fn clone_fn_wrapper(expr: &FFI_PhysicalExpr) -> FFI_PhysicalEx
             propagate_statistics: propagate_statistics_fn_wrapper,
             get_properties: get_properties_fn_wrapper,
             fmt_sql: fmt_sql_fn_wrapper,
+            #[expect(deprecated)]
             snapshot: snapshot_fn_wrapper,
             snapshot_generation: snapshot_generation_fn_wrapper,
             is_volatile_node: is_volatile_node_fn_wrapper,
@@ -471,6 +476,7 @@ impl From<Arc<dyn PhysicalExpr>> for FFI_PhysicalExpr {
             propagate_statistics: propagate_statistics_fn_wrapper,
             get_properties: get_properties_fn_wrapper,
             fmt_sql: fmt_sql_fn_wrapper,
+            #[expect(deprecated)]
             snapshot: snapshot_fn_wrapper,
             snapshot_generation: snapshot_generation_fn_wrapper,
             is_volatile_node: is_volatile_node_fn_wrapper,
@@ -941,16 +947,6 @@ mod tests {
         assert_eq!(left, right);
     }
 
-    #[test]
-    fn ffi_physical_expr_snapshot_generation() {
-        let (original, foreign_expr) = create_test_expr();
-
-        assert_eq!(
-            original.snapshot_generation(),
-            foreign_expr.snapshot_generation()
-        );
-    }
-
     #[test]
     fn ffi_physical_expr_volatility() {
         let (original, foreign_expr) = create_test_expr();