fix

Author: xiedeyantu

datafusion/functions/src/math/factorial.rs

@@ -23,7 +23,7 @@ use arrow::datatypes::{DECIMAL256_MAX_PRECISION, DataType, Int64Type};
 use arrow_buffer::i256;
 
 use datafusion_common::{
-    DataFusionError, Result, ScalarValue, internal_err, utils::take_function_args,
+    internal_err, utils::take_function_args, DataFusionError, Result, ScalarValue,
 };
 use datafusion_expr::{
     ColumnarValue, Documentation, ScalarFunctionArgs, ScalarUDFImpl, Signature,
@@ -172,5 +172,11 @@ fn compute_factorial(n: i64) -> Result<i256> {
         })?;
     }
 
+    if result.to_string().len() > DECIMAL256_MAX_PRECISION as usize {
+        return Err(DataFusionError::Execution(format!(
+            "Overflow happened on FACTORIAL({n})"
+        )));
+    }
+
     Ok(result)
 }

datafusion/sqllogictest/test_files/scalar.slt

@@ -476,6 +476,14 @@ select factorial(21);
 ----
 51090942171709440000
 
+query TR
+select arrow_typeof(factorial(56)), factorial(56);
+----
+Decimal256(76, 0) 710998587804863451854045647463724949736497978881168458687447040000000000000
+
+query error DataFusion error: Execution error: Overflow happened on FACTORIAL\(57\)
+select factorial(57);
+
 # factorial scalar nulls
 query R rowsort
 select factorial(null);