Add .slt tests

Author: shivbhatia10

datafusion/spark/src/function/math/floor.rs

@@ -31,8 +31,12 @@ use datafusion_expr::{
 /// <https://spark.apache.org/docs/latest/api/sql/index.html#floor>
 ///
 /// Differences with DataFusion floor:
-///  - Spark's floor returns Int64 for float/integer types
-///  - Spark's floor adjusts precision for Decimal128 types
+///  - Spark's floor returns Int64 for float and integer inputs; DataFusion preserves
+///    the input type (Float32→Float32, Float64→Float64, integers coerced to Float64)
+///  - Spark's floor on Decimal128(p, s) returns Decimal128(p−s+1, 0), reducing scale
+///    to 0; DataFusion preserves the original precision and scale
+///  - Spark only supports Decimal128; DataFusion also supports Decimal32/64/256
+///  - Spark does not check for decimal overflow; DataFusion errors on overflow
 #[derive(Debug, PartialEq, Eq, Hash)]
 pub struct SparkFloor {
     signature: Signature,

datafusion/sqllogictest/test_files/spark/math/floor.slt

@@ -23,20 +23,125 @@
 
 ## Original Query: SELECT floor(-0.1);
 ## PySpark 3.5.5 Result: {'FLOOR(-0.1)': Decimal('-1'), 'typeof(FLOOR(-0.1))': 'decimal(1,0)', 'typeof(-0.1)': 'decimal(1,1)'}
-#query
-#SELECT floor(-0.1::decimal(1,1));
+query R
+SELECT floor(-0.1::decimal(1,1));
+----
+-1
 
 ## Original Query: SELECT floor(3.1411, -3);
 ## PySpark 3.5.5 Result: {'floor(3.1411, -3)': Decimal('0'), 'typeof(floor(3.1411, -3))': 'decimal(4,0)', 'typeof(3.1411)': 'decimal(5,4)', 'typeof(-3)': 'int'}
+## TODO: 2-argument floor(value, scale) is not yet implemented
 #query
 #SELECT floor(3.1411::decimal(5,4), -3::int);
 
 ## Original Query: SELECT floor(3.1411, 3);
 ## PySpark 3.5.5 Result: {'floor(3.1411, 3)': Decimal('3.141'), 'typeof(floor(3.1411, 3))': 'decimal(5,3)', 'typeof(3.1411)': 'decimal(5,4)', 'typeof(3)': 'int'}
+## TODO: 2-argument floor(value, scale) is not yet implemented
 #query
 #SELECT floor(3.1411::decimal(5,4), 3::int);
 
 ## Original Query: SELECT floor(5);
 ## PySpark 3.5.5 Result: {'FLOOR(5)': 5, 'typeof(FLOOR(5))': 'bigint', 'typeof(5)': 'int'}
-#query
-#SELECT floor(5::int);
+query I
+SELECT floor(5::int);
+----
+5
+
+# Scalar input: float64 returns bigint
+query IIIIIII
+SELECT floor(125.9345::DOUBLE), floor(15.9999::DOUBLE), floor(0.9::DOUBLE), floor(-0.1::DOUBLE), floor(-1.999::DOUBLE), floor(123.0::DOUBLE), floor(NULL::DOUBLE);
+----
+125 15 0 -1 -2 123 NULL
+
+# Scalar input: float32 returns bigint
+query IIIIIII
+SELECT floor(125.9345::FLOAT), floor(15.9999::FLOAT), floor(0.9::FLOAT), floor(-0.1::FLOAT), floor(-1.999::FLOAT), floor(123.0::FLOAT), floor(NULL::FLOAT);
+----
+125 15 0 -1 -2 123 NULL
+
+# Scalar input: integer types all return bigint
+query III
+SELECT floor(5::TINYINT), floor(-3::TINYINT), floor(NULL::TINYINT);
+----
+5 -3 NULL
+
+query III
+SELECT floor(5::SMALLINT), floor(-3::SMALLINT), floor(NULL::SMALLINT);
+----
+5 -3 NULL
+
+query III
+SELECT floor(5::INT), floor(-3::INT), floor(NULL::INT);
+----
+5 -3 NULL
+
+query III
+SELECT floor(5::BIGINT), floor(-3::BIGINT), floor(NULL::BIGINT);
+----
+5 -3 NULL
+
+# Scalar input: decimal128 with scale > 0 returns decimal with scale 0
+# floor(1.50) = 1, floor(-1.50) = -2, floor(1.00) = 1
+query RRR
+SELECT floor(1.50::DECIMAL(10, 2)), floor(-1.50::DECIMAL(10, 2)), floor(1.00::DECIMAL(10, 2));
+----
+1 -2 1
+
+# floor(-0.1) = -1 (rounds down away from zero for negatives)
+query RR
+SELECT floor(-0.1::DECIMAL(3, 1)), floor(NULL::DECIMAL(10, 2));
+----
+-1 NULL
+
+# floor(3.1411) = 3
+query R
+SELECT floor(3.1411::DECIMAL(5, 4));
+----
+3
+
+# Scalar input: decimal128 with scale = 0 passes through unchanged
+query RRR
+SELECT floor(5::DECIMAL(10, 0)), floor(-3::DECIMAL(10, 0)), floor(NULL::DECIMAL(10, 0));
+----
+5 -3 NULL
+
+# Array input: float64
+query I
+SELECT floor(a) FROM (VALUES (125.9345::DOUBLE), (15.9999::DOUBLE), (0.9::DOUBLE), (-0.1::DOUBLE), (-1.999::DOUBLE), (123.0::DOUBLE), (NULL::DOUBLE)) AS t(a);
+----
+125
+15
+0
+-1
+-2
+123
+NULL
+
+# Array input: float32
+query I
+SELECT floor(a) FROM (VALUES (125.9345::FLOAT), (15.9999::FLOAT), (0.9::FLOAT), (-0.1::FLOAT), (-1.999::FLOAT), (123.0::FLOAT), (NULL::FLOAT)) AS t(a);
+----
+125
+15
+0
+-1
+-2
+123
+NULL
+
+# Array input: integers
+query I
+SELECT floor(a) FROM (VALUES (5::INT), (-3::INT), (NULL::INT)) AS t(a);
+----
+5
+-3
+NULL
+
+# Array input: decimal128 with scale > 0
+query R
+SELECT floor(a) FROM (VALUES (1.50::DECIMAL(10, 2)), (-1.50::DECIMAL(10, 2)), (1.00::DECIMAL(10, 2)), (NULL::DECIMAL(10, 2))) AS t(a);
+----
+1
+-2
+1
+NULL