Skip to content

Commit d3983d3

Browse files
authored
chore: fix two comment typos (#22524)
## Summary - `datafusion/physical-plan/src/aggregates/group_values/multi_group_by/mod.rs:737` - `scalarized_intern_remaining` doc said "preform" → "perform" - `datafusion/core/tests/dataframe/mod.rs:843,895,943` - three nearly-identical test comments said "functionally dependant" → "functionally dependent" Comment-only. Co-authored-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
1 parent 04c01bb commit d3983d3

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

  • datafusion
    • core/tests/dataframe
    • physical-plan/src/aggregates/group_values/multi_group_by

datafusion/core/tests/dataframe/mod.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -840,7 +840,7 @@ async fn test_aggregate_with_pk() -> Result<()> {
840840
let aggr_expr = vec![];
841841
let df = df.aggregate(group_expr, aggr_expr)?;
842842

843-
// Since id and name are functionally dependant, we can use name among
843+
// Since id and name are functionally dependent, we can use name among
844844
// expression even if it is not part of the group by expression and can
845845
// select "name" column even though it wasn't explicitly grouped
846846
let df = df.select(vec![col("id"), col("name")])?;
@@ -895,7 +895,7 @@ async fn test_aggregate_with_pk2() -> Result<()> {
895895
"
896896
);
897897

898-
// Since id and name are functionally dependant, we can use name among expression
898+
// Since id and name are functionally dependent, we can use name among expression
899899
// even if it is not part of the group by expression.
900900
let df_results = df.collect().await?;
901901

@@ -943,7 +943,7 @@ async fn test_aggregate_with_pk3() -> Result<()> {
943943
"
944944
);
945945

946-
// Since id and name are functionally dependant, we can use name among expression
946+
// Since id and name are functionally dependent, we can use name among expression
947947
// even if it is not part of the group by expression.
948948
let df_results = df.collect().await?;
949949

datafusion/physical-plan/src/aggregates/group_values/multi_group_by/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -734,7 +734,7 @@ impl<const STREAMING: bool> GroupValuesColumn<STREAMING> {
734734
///
735735
/// The hash collision may be not frequent, so the fallback will indeed hardly happen.
736736
/// In most situations, `scalarized_indices` will found to be empty after finishing to
737-
/// preform `vectorized_equal_to`.
737+
/// perform `vectorized_equal_to`.
738738
fn scalarized_intern_remaining(
739739
&mut self,
740740
cols: &[ArrayRef],

0 commit comments

Comments
 (0)