Commit da05287
Fix FileStream scanning_total to include sync next-file open time (#20627)
## Summary
- include synchronous `start_next_file()` / `FileOpener::open()` setup
time in `time_elapsed_scanning_total`
- keep existing `time_opening` and scanning timers lifecycle intact
- avoid timer overlap by scoping the temporary timer before calling
`time_scanning_total.start()`
## Details
In `FileStreamState::Open`, `start_next_file()` is invoked before
`time_scanning_total.start()`. If `open()` performs synchronous work
before returning the future, that time was previously unaccounted for in
`time_elapsed_scanning_total`.
This change wraps the `start_next_file()` call in a scoped timer on the
same `time_scanning_total` metric so the missing segment is recorded.
- Fixes #20571
## Validation
I tested by reading CSV files via AWS S3.
---------
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>1 parent 4bac1cf commit da05287
1 file changed
+9
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
127 | 127 | | |
128 | 128 | | |
129 | 129 | | |
130 | | - | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
131 | 139 | | |
132 | 140 | | |
133 | 141 | | |
| |||
0 commit comments