Skip to content

Commit dcaa80c

Browse files
Address review comments
Co-authored-by: Martin Grigorov <martin-g@users.noreply.github.com>
1 parent a841b13 commit dcaa80c

File tree

1 file changed

+6
-6
lines changed
  • datafusion/spark/src/function/array

1 file changed

+6
-6
lines changed

datafusion/spark/src/function/array/slice.rs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -97,8 +97,8 @@ impl ScalarUDFImpl for SparkSlice {
9797
mut func_args: ScalarFunctionArgs,
9898
) -> Result<ColumnarValue> {
9999
if func_args.args[0].data_type() == DataType::Null {
100-
return Ok::<ColumnarValue, DataFusionError>(func_args.args[0].clone());
101-
};
100+
return Ok(func_args.args[0].clone());
101+
}
102102

103103
let array_len = func_args
104104
.args
@@ -194,13 +194,13 @@ mod tests {
194194
];
195195

196196
let args = ScalarFunctionArgs {
197-
args: input_args.to_owned(),
197+
args: input_args,
198198
arg_fields: vec![Arc::new(Field::new(
199199
"item",
200-
List(FieldRef::new(Field::new("", DataType::Int64, true))),
200+
List(FieldRef::new(Field::new("f", DataType::Int64, true))),
201201
false,
202202
))],
203-
number_rows: 0,
203+
number_rows: 1,
204204
return_field: Arc::new(Field::new(
205205
"item",
206206
List(FieldRef::new(Field::new_list_field(DataType::Int64, true))),
@@ -210,6 +210,6 @@ mod tests {
210210
};
211211
let slice = SparkSlice::new();
212212
let result = slice.invoke_with_args(args).unwrap();
213-
assert!(result.to_array(1).unwrap() == Arc::new(NullArray::new(1)));
213+
assert_eq!(result.to_array(1).unwrap(), Arc::new(NullArray::new(1)));
214214
}
215215
}

0 commit comments

Comments
 (0)