address review: split benchmarks to follow-up PR, clarify Unsupported comment

- Remove benchmark code (sort_pushdown.rs, bench.sh, dfbench.rs changes)
  to be submitted as a separate follow-up PR per reviewer request
- Clarify "Unsupported if already in order" in architecture diagram:
  explain that Unsupported means no change was made to the plan

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: zhuqi-lucas

benchmarks/bench.sh

@@ -106,10 +106,6 @@ clickbench_partitioned: ClickBench queries against partitioned (100 files) parqu
 clickbench_pushdown:    ClickBench queries against partitioned (100 files) parquet w/ filter_pushdown enabled
 clickbench_extended:    ClickBench \"inspired\" queries against a single parquet (DataFusion specific)
 
-# Sort Pushdown Benchmarks
-sort_pushdown:          Sort pushdown baseline (no WITH ORDER) on TPC-H data (SF=1)
-sort_pushdown_sorted:   Sort pushdown with WITH ORDER — tests sort elimination on non-overlapping files
-
 # Sorted Data Benchmarks (ORDER BY Optimization)
 clickbench_sorted:     ClickBench queries on pre-sorted data using prefer_existing_sort (tests sort elimination optimization)
 
@@ -313,10 +309,6 @@ main() {
                     # same data as for tpch
                     data_tpch "1" "parquet"
                     ;;
-                sort_pushdown|sort_pushdown_sorted)
-                    # same data as for tpch
-                    data_tpch "1" "parquet"
-                    ;;
                 sort_tpch)
                     # same data as for tpch
                     data_tpch "1" "parquet"
@@ -517,12 +509,6 @@ main() {
                 external_aggr)
                     run_external_aggr
                     ;;
-                sort_pushdown)
-                    run_sort_pushdown
-                    ;;
-                sort_pushdown_sorted)
-                    run_sort_pushdown_sorted
-                    ;;
                 sort_tpch)
                     run_sort_tpch "1"
                     ;;
@@ -1084,22 +1070,6 @@ run_external_aggr() {
     debug_run $CARGO_COMMAND --bin external_aggr -- benchmark --partitions 4 --iterations 5 --path "${TPCH_DIR}" -o "${RESULTS_FILE}" ${QUERY_ARG}
 }
 
-# Runs the sort pushdown benchmark (without WITH ORDER)
-run_sort_pushdown() {
-    TPCH_DIR="${DATA_DIR}/tpch_sf1"
-    RESULTS_FILE="${RESULTS_DIR}/sort_pushdown.json"
-    echo "Running sort pushdown benchmark (no WITH ORDER)..."
-    debug_run $CARGO_COMMAND --bin dfbench -- sort-pushdown --iterations 5 --path "${TPCH_DIR}" -o "${RESULTS_FILE}" ${QUERY_ARG} ${LATENCY_ARG}
-}
-
-# Runs the sort pushdown benchmark with WITH ORDER (enables sort elimination)
-run_sort_pushdown_sorted() {
-    TPCH_DIR="${DATA_DIR}/tpch_sf1"
-    RESULTS_FILE="${RESULTS_DIR}/sort_pushdown_sorted.json"
-    echo "Running sort pushdown benchmark (with WITH ORDER)..."
-    debug_run $CARGO_COMMAND --bin dfbench -- sort-pushdown --sorted --iterations 5 --path "${TPCH_DIR}" -o "${RESULTS_FILE}" ${QUERY_ARG} ${LATENCY_ARG}
-}
-
 # Runs the sort integration benchmark
 run_sort_tpch() {
     SCALE_FACTOR=$1

benchmarks/src/bin/dfbench.rs

@@ -34,8 +34,7 @@ static ALLOC: snmalloc_rs::SnMalloc = snmalloc_rs::SnMalloc;
 static ALLOC: mimalloc::MiMalloc = mimalloc::MiMalloc;
 
 use datafusion_benchmarks::{
-    cancellation, clickbench, h2o, hj, imdb, nlj, smj, sort_pushdown, sort_tpch, tpcds,
-    tpch,
+    cancellation, clickbench, h2o, hj, imdb, nlj, smj, sort_tpch, tpcds, tpch,
 };
 
 #[derive(Debug, Parser)]
@@ -54,7 +53,6 @@ enum Options {
     Imdb(imdb::RunOpt),
     Nlj(nlj::RunOpt),
     Smj(smj::RunOpt),
-    SortPushdown(sort_pushdown::RunOpt),
     SortTpch(sort_tpch::RunOpt),
     Tpch(tpch::RunOpt),
     Tpcds(tpcds::RunOpt),
@@ -74,7 +72,6 @@ pub async fn main() -> Result<()> {
         Options::Imdb(opt) => Box::pin(opt.run()).await,
         Options::Nlj(opt) => opt.run().await,
         Options::Smj(opt) => opt.run().await,
-        Options::SortPushdown(opt) => opt.run().await,
         Options::SortTpch(opt) => opt.run().await,
         Options::Tpch(opt) => Box::pin(opt.run()).await,
         Options::Tpcds(opt) => Box::pin(opt.run()).await,

benchmarks/src/lib.rs

@@ -23,7 +23,6 @@ pub mod hj;
 pub mod imdb;
 pub mod nlj;
 pub mod smj;
-pub mod sort_pushdown;
 pub mod sort_tpch;
 pub mod tpcds;
 pub mod tpch;