Commit f755cb4
authored
feat: Support BinaryView type in approx_distinct (#23333)
## Which issue does this PR close?
- Relates to #22989 but does
not close it. More types are coming.
## Rationale for this change
- Support the `BinaryView` type for `approx_distinct`
- The Arrow type `BinaryView` can be directly supported for
`HLLAccumulator` and `HllGroupsAccumulator`
## What changes are included in this PR?
- Enable `HLLAccumulator` and `HllGroupsAccumulator` to support
`BinaryView`
- Tests for the non-grouped and grouped path as part of `aggregate.slt`
## Are these changes tested?
Yes
## Are there any user-facing changes?
Yes, `approx_distinct` supports now `BinaryView` but no breaking
changes.1 parent 0365d3c commit f755cb4
2 files changed
Lines changed: 19 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
798 | 798 | | |
799 | 799 | | |
800 | 800 | | |
| 801 | + | |
801 | 802 | | |
802 | 803 | | |
803 | 804 | | |
| |||
866 | 867 | | |
867 | 868 | | |
868 | 869 | | |
| 870 | + | |
869 | 871 | | |
870 | 872 | | |
871 | 873 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1936 | 1936 | | |
1937 | 1937 | | |
1938 | 1938 | | |
| 1939 | + | |
| 1940 | + | |
| 1941 | + | |
| 1942 | + | |
| 1943 | + | |
| 1944 | + | |
| 1945 | + | |
| 1946 | + | |
| 1947 | + | |
| 1948 | + | |
| 1949 | + | |
| 1950 | + | |
| 1951 | + | |
| 1952 | + | |
| 1953 | + | |
| 1954 | + | |
| 1955 | + | |
1939 | 1956 | | |
1940 | 1957 | | |
1941 | 1958 | | |
| |||
0 commit comments