Link range partitioning follow-up issues

Author: gene-bordegaray

datafusion/ffi/src/physical_expr/partitioning.rs

@@ -46,6 +46,7 @@ impl From<&Partitioning> for FFI_Partitioning {
                 Self::Hash(exprs, *size)
             }
             // FFI does not yet expose range partition metadata.
+            // See https://github.com/apache/datafusion/issues/22394
             Partitioning::Range(range) => {
                 Self::UnknownPartitioning(range.partition_count())
             }

datafusion/physical-expr/src/partitioning.rs

@@ -161,6 +161,7 @@ impl Display for Partitioning {
 /// partition 0: key < split_points[0]
 /// partition 1: split_points[0] <= key < split_points[1]
 /// ...
+/// partition N - 1: split_points[N - 2] <= key < split_points[N - 1]
 /// partition N: split_points[N - 1] <= key
 /// ```
 ///
@@ -201,12 +202,9 @@ impl Display for Partitioning {
 /// not implemented and will be introduced incrementally.
 #[derive(Debug, Clone)]
 pub struct RangePartitioning {
-    /// Ordered partitioning key. Sort options are part of the partitioning
-    /// because `ASC`/`DESC` and null ordering decide which side of a split point
-    /// a row belongs to.
+    /// Ordered partitioning key.
     ordering: LexOrdering,
-    /// Boundaries between adjacent partitions. `N` split points define `N + 1`
-    /// partitions as described in [`RangePartitioning`].
+    /// Boundaries between adjacent partitions.
     split_points: Vec<SplitPoint>,
 }
 

datafusion/physical-plan/src/joins/utils.rs

@@ -145,6 +145,8 @@ pub fn adjust_right_output_partitioning(
             Partitioning::Hash(new_exprs, *size)
         }
         Partitioning::Range(_) => {
+            // Range partitioning optimizer propagation is tracked in
+            // https://github.com/apache/datafusion/issues/22395
             return not_impl_err!(
                 "Join output partitioning with range partitioning is not implemented"
             );

datafusion/physical-plan/src/repartition/mod.rs

@@ -739,6 +739,8 @@ impl BatchPartitioner {
                 ))
             }
             Partitioning::Range(_) => {
+                // Range repartition execution is tracked in
+                // https://github.com/apache/datafusion/issues/22397
                 not_impl_err!(
                     "Range partitioning execution is not implemented by RepartitionExec"
                 )
@@ -1452,6 +1454,8 @@ impl ExecutionPlan for RepartitionExec {
                 Partitioning::Hash(new_partitions, *size)
             }
             Partitioning::Range(_) => {
+                // Range partitioning optimizer propagation is tracked in
+                // https://github.com/apache/datafusion/issues/22395
                 return not_impl_err!(
                     "Projection pushdown through RepartitionExec with range partitioning is not implemented"
                 );
@@ -1494,6 +1498,8 @@ impl ExecutionPlan for RepartitionExec {
         }
         match self.partitioning() {
             Partitioning::Range(_) => {
+                // Range partitioning optimizer propagation is tracked in
+                // https://github.com/apache/datafusion/issues/22395
                 return not_impl_err!(
                     "Sort pushdown through RepartitionExec with range partitioning is not implemented"
                 );
@@ -1526,6 +1532,8 @@ impl ExecutionPlan for RepartitionExec {
             Hash(hash, _) => Hash(hash, target_partitions),
             UnknownPartitioning(_) => UnknownPartitioning(target_partitions),
             Range(_) => {
+                // Range repartition execution is tracked in
+                // https://github.com/apache/datafusion/issues/22397
                 return not_impl_err!(
                     "Changing RepartitionExec partition counts with range partitioning is not implemented"
                 );
@@ -1659,6 +1667,8 @@ impl RepartitionExec {
                 )
             }
             Partitioning::Range(_) => {
+                // Range repartition execution is tracked in
+                // https://github.com/apache/datafusion/issues/22397
                 return not_impl_err!(
                     "Range partitioning execution is not implemented by RepartitionExec"
                 );

datafusion/physical-plan/src/sorts/sort.rs

@@ -1142,7 +1142,8 @@ impl ExecutionPlan for SortExec {
             vec![Distribution::UnspecifiedDistribution]
         } else {
             // global sort
-            // TODO support RangePartition and OrderedDistribution
+            // TODO support range partitioning and OrderedDistribution.
+            // See https://github.com/apache/datafusion/issues/22395
             vec![Distribution::SinglePartition]
         }
     }