Extract out date time parsing to a DateTimeParser trait

[Omega359]

Which issue does this PR close?

• Part of feat: Pluggable datetime parsing #19754 (to_timestamp, to_date functions)

Rationale for this change

Allowing pluggable datatime string parsing. Extracted existing Chrono implementation, added Jiff implementation. Overall Jiff is faster in the case where parsing has no errors but slower when using multiple formats (higher cost for Error handling).

What changes are included in this PR?

Code, tests, benchmark.

Are these changes tested?

Yes.

Are there any user-facing changes?

By default, no.

[Omega359]

Thanks for the feedback @martin-g. I'm not quite done with this PR but I'll be sure to incorporate your fixes/suggestions before I set it as ready for review

[Omega359]

@martin-g Thank you for the detailed feedback. I've implemented almost all of your suggestions

[Omega359]

fyi @andygrove this may be of interest for spark to_date, to_timestamp, etc functions if someone was to create a Java datetimeparser impl that had a compatible license.

[github-actions]

Thank you for opening this pull request!

Reviewer note: cargo-semver-checks reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch).

Details

     Cloning apache/main
    Building datafusion v53.1.0 (current)
       Built [  93.620s] (current)
     Parsing datafusion v53.1.0 (current)
      Parsed [   0.035s] (current)
    Building datafusion v53.1.0 (baseline)
       Built [  92.037s] (baseline)
     Parsing datafusion v53.1.0 (baseline)
      Parsed [   0.035s] (baseline)
    Checking datafusion v53.1.0 -> v53.1.0 (no change; assume patch)
     Checked [   0.598s] 222 checks: 222 pass, 30 skip
     Summary no semver update required
    Finished [ 188.326s] datafusion
    Building datafusion-common v53.1.0 (current)
       Built [  31.820s] (current)
     Parsing datafusion-common v53.1.0 (current)
      Parsed [   0.057s] (current)
    Building datafusion-common v53.1.0 (baseline)
       Built [  31.795s] (baseline)
     Parsing datafusion-common v53.1.0 (baseline)
      Parsed [   0.057s] (baseline)
    Checking datafusion-common v53.1.0 -> v53.1.0 (no change; assume patch)
     Checked [   0.646s] 222 checks: 221 pass, 1 fail, 0 warn, 30 skip

--- failure constructible_struct_adds_field: externally-constructible struct adds field ---

Description:
A pub struct constructible with a struct literal has a new pub field. Existing struct literals must be updated to include the new field.
        ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/constructible_struct_adds_field.ron

Failed in:
  field ExecutionOptions.date_time_parser in /home/runner/work/datafusion/datafusion/datafusion/common/src/config.rs:469

     Summary semver requires new major version: 1 major and 0 minor checks failed
    Finished [  65.627s] datafusion-common
    Building datafusion-functions v53.1.0 (current)
       Built [  28.335s] (current)
     Parsing datafusion-functions v53.1.0 (current)
      Parsed [   0.082s] (current)
    Building datafusion-functions v53.1.0 (baseline)
       Built [  28.016s] (baseline)
     Parsing datafusion-functions v53.1.0 (baseline)
      Parsed [   0.079s] (baseline)
    Checking datafusion-functions v53.1.0 -> v53.1.0 (no change; assume patch)
     Checked [   0.391s] 222 checks: 220 pass, 2 fail, 0 warn, 30 skip

--- failure function_parameter_count_changed: pub fn parameter count changed ---

Description:
A publicly-visible function now takes a different number of parameters.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/function_parameter_count_changed.ron

Failed in:
  datafusion_functions::datetime::to_date now takes 1 parameters instead of 0, in /home/runner/work/datafusion/datafusion/datafusion/functions/src/datetime/mod.rs:53

--- failure type_method_marked_deprecated: type method #[deprecated] added ---

Description:
A type method is now #[deprecated]. Downstream crates will get a compiler warning when using this method.
        ref: https://doc.rust-lang.org/reference/attributes/diagnostics.html#the-deprecated-attribute
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/type_method_marked_deprecated.ron

Failed in:
  method datafusion_functions::datetime::to_date::ToDateFunc::new in /home/runner/work/datafusion/datafusion/datafusion/functions/src/datetime/to_date.rs:87

     Summary semver requires new major version: 1 major and 1 minor checks failed
    Finished [  58.315s] datafusion-functions
    Building datafusion-sqllogictest v53.1.0 (current)
       Built [ 159.115s] (current)
     Parsing datafusion-sqllogictest v53.1.0 (current)
      Parsed [   0.021s] (current)
    Building datafusion-sqllogictest v53.1.0 (baseline)
       Built [ 158.371s] (baseline)
     Parsing datafusion-sqllogictest v53.1.0 (baseline)
      Parsed [   0.022s] (baseline)
    Checking datafusion-sqllogictest v53.1.0 -> v53.1.0 (no change; assume patch)
     Checked [   0.084s] 222 checks: 222 pass, 30 skip
     Summary no semver update required
    Finished [ 320.888s] datafusion-sqllogictest

[Omega359]

No review in 4 months, this feature is not desired. closing.

[ianthetechie]

That's too bad 😅 I had been keeping half an eye hoping for a version of this to be merged. Even ignoring speed, jiff is now recommended by the maintainer of chrono (which was recently deprecated).

[Omega359]

I had to hunt for the soft deprecation notice - it's @ chronotope/chrono#1768 for anyone who wants to read more on it.