Skip to content

Fix FileStream scanning_total to include sync next-file open time #20627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 3 commits into from
Mar 11, 2026
+9 −1
Merged

Fix FileStream scanning_total to include sync next-file open time #20627

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c98ae53
Fix FileStream scanning_total to include sync next-file open time
RatulDawar Mar 1, 2026
b8dd957
Apply rustfmt in file_stream timer metric block
RatulDawar Mar 4, 2026
52ec21b
Merge branch 'main' into fix-20571-file-stream-scanning-timer
alamb Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion datafusion/datasource/src/file_stream.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,15 @@ impl FileStream {
self.file_stream_metrics.files_opened.add(1);
// include time needed to start opening in `start_next_file`
self.file_stream_metrics.time_opening.stop();
let next = self.start_next_file().transpose();
let next = {
Copy link
Copy Markdown
Contributor

@alamb alamb Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if there is any way to make this more concise (to avoid complicating the FileStream more).

Perhaps a method on `file_stream_metrics so this could look like

 let scanning_total_metric = self.file_stream_metrics.time_scanning_total.timer()` 🤔

let scanning_total_metric = self
.file_stream_metrics
.time_scanning_total
.metrics
.clone();
let _timer = scanning_total_metric.timer();
self.start_next_file().transpose()
};
self.file_stream_metrics.time_scanning_until_data.start();
self.file_stream_metrics.time_scanning_total.start();

Expand Down