Update repeat UDF to emit utf8view when input is utf8view#20645
Merged
alamb merged 10 commits intoapache:mainfrom Mar 31, 2026
Merged
Update repeat UDF to emit utf8view when input is utf8view#20645alamb merged 10 commits intoapache:mainfrom
alamb merged 10 commits intoapache:mainfrom
Conversation
11 tasks
Contributor
|
run benchmark repeat |
|
🤖 Criterion benchmark running (GKE) | trigger CPU Details (lscpu)Comparing repeat_utf8view (2bbc3ad) to 9b726bc (merge-base) diff File an issue against this benchmark runner |
|
🤖 Criterion benchmark completed (GKE) | trigger Instance: CPU Details (lscpu)Details
Resource Usagebase (merge-base)
branch
File an issue against this benchmark runner |
Contributor
|
Thanks again @Omega359 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #20585
Rationale for this change
Functions ideally should emit strings in the same format as the input and previously the repeat function was emitting using utf8 for input that was in utf8view.
What changes are included in this PR?
Code, tests
Are these changes tested?
Yes
Are there any user-facing changes?