sql: render PostgreSQL array literals as ARRAY[...] in unparser#21513
Open
xiedeyantu wants to merge 1 commit intoapache:mainfrom
Open
sql: render PostgreSQL array literals as ARRAY[...] in unparser#21513xiedeyantu wants to merge 1 commit intoapache:mainfrom
xiedeyantu wants to merge 1 commit intoapache:mainfrom
Conversation
Member
Author
|
@metegenez Could you please help me review this PR? |
Contributor
|
Sure, tomorrow I'll look at it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
PostgreSQL array literals should be rendered using
ARRAY[...]syntax when unparsing SQL. Without this, roundtripped PostgreSQL SQL can lose the dialect-specific array form and emit a plain bracketed array literal instead.What changes are included in this PR?
ARRAY[...].PostgreSqlDialect.ARRAY[1, 2, 3, 4, 5].Are these changes tested?
Yes. The PostgreSQL roundtrip test in plan_to_sql.rs covers the array literal case and verifies the unparsed SQL now uses
ARRAY[...].Are there any user-facing changes?
Yes. PostgreSQL SQL generated by DataFusion will now emit array literals in
ARRAY[...]form instead of plain bracketed form.