perf: Optimize NULL handling in array_remove#21532
Merged
mbutrovich merged 2 commits intoapache:mainfrom Apr 10, 2026
Merged
Conversation
Contributor
Author
|
@Jefffrey Thanks for the review! Shameless plug: If you enjoyed reviewing this PR, there are many such similar PRs you might also enjoy 😉 |
mbutrovich
approved these changes
Apr 10, 2026
Contributor
mbutrovich
left a comment
There was a problem hiding this comment.
Thanks @neilconway! These are great improvements across the codebase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
array_remove#21531.Rationale for this change
array_removecomputes the result NULL bitmap incrementally (row-by-row). This is inefficient; it is faster to compute the result NULL bitmap via the bitwise AND of the input NULL bitmaps.Benchmarks (Arm64):
Not a massive win, but I think still worth making the change; the resulting code is also more idiomatic.
What changes are included in this PR?
array_removebenchmark for f64: the previous code resulted in never actually removing anything from the array, which was inconsistent with the other benchmarks and probably unintentional.Are these changes tested?
Yes.
Are there any user-facing changes?
No.