You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Rationale for this change
Issue #21516 reports that Spark-mode SQL string literals such as '\thello' and '\nhello' are treated as literal backslash text instead of using Spark-compatible escape handling. This fix should address all string functions not just soundex and length. This should improve matching functionality between pyspark and datafusion-spark
What changes are included in this PR?
I added a Spark-only SQL parser option: 'datafusion.sql_parser.spark_string_literal_unescape'
threaded the option through 'ParserOptions'
updated 'datafusion/sql/src/expr/value.rs' to unescape string literals only when the Spark-only option is enabled
enabled the option from 'with_spark_features()' in 'datafusion/spark/src/session_state.rs'
updated tests and sqllogictest expectations and test snapshots
Are these changes tested?
Yes. I tested the change with these commands:
cargo test -p datafusion
cargo test -p datafusion-sql
cargo test -p datafusion-spark
cargo test --profile=ci --test sqllogictests
Are there any user-facing changes?
Yes, there are user-facing changes. In Spark mode, SQL string literals now use Spark-compatible backslash escape handling. Generic DataFusion SQL behavior is unchanged.
Sorry about that, I hadn't seen I should've ran sqllogictests. How exactly would I run the linter locally or what webpage would I find that as I see that I had forgot to add the header to a test file I had created.
Sorry about that, I hadn't seen I should've ran sqllogictests. How exactly would I run the linter locally or what webpage would I find that as I see that I had forgot to add the header to a test file I had created.
run cargo fmt: cargo fmt --all
run clippy: cargo clippy --workspace --all-features --all-targets -- --deny=warnings
run sqllogictest: make -C testing/runner test-sqlite
I ran cargo fit --all, I've been having issues running clippy, I had been getting errors for files unrelated to any changes I made (I think there's something wrong with my build environment, I didn't even have cmake). For the sqllogic tests command you gave is that a different test than what I ran in my PR request information or something else? Also, what directory would I run the command make -C testing/runner test-sqlite. In the directories I have ran it in so far it says testing/runner not found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #21516
Rationale for this change
Issue #21516 reports that Spark-mode SQL string literals such as '\thello' and '\nhello' are treated as literal backslash text instead of using Spark-compatible escape handling. This fix should address all string functions not just soundex and length. This should improve matching functionality between pyspark and datafusion-spark
What changes are included in this PR?
Are these changes tested?
Yes. I tested the change with these commands:
cargo test -p datafusion
cargo test -p datafusion-sql
cargo test -p datafusion-spark
cargo test --profile=ci --test sqllogictests
Are there any user-facing changes?
Yes, there are user-facing changes. In Spark mode, SQL string literals now use Spark-compatible backslash escape handling. Generic DataFusion SQL behavior is unchanged.