fix(proto): correctly serialize FilterExec empty projection#21885
Merged
Conversation
Contributor
Author
|
@askalt , can you look into this ? |
Contributor
Author
askalt
reviewed
Apr 28, 2026
Contributor
|
@Adez017 Thank you for the patch! |
askalt
approved these changes
Apr 28, 2026
Jefffrey
reviewed
Apr 28, 2026
Contributor
Author
|
Hi @Jefffrey , i had pushed the changes as per comments , take a look now . |
Jefffrey
approved these changes
Apr 29, 2026
Contributor
Author
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
FilterExecempty projection is changed to full projection after serde #21871Rationale for this change
FilterExec supports two semantically different projection states:
However, both cases were being serialized identically as an empty vector in the proto representation. During deserialization, an empty vector was always mapped back to None, meaning an empty projection would silently become a full projection after a serde round-trip.
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?
No