-
Notifications
You must be signed in to change notification settings - Fork 2.1k
fix(proto): correctly serialize FilterExec empty projection #21885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+58
−13
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
8562f72
Refactor projection handling in FilterExecBuilder
Adez017 e890283
Update roundtrip_physical_plan.rs
Adez017 89c4328
added deserialization
Adez017 9951c16
fmt
Adez017 896120b
fix test
Adez017 2ba3a97
Fix projection assertions in roundtrip tests
Adez017 6847a16
Update roundtrip_physical_plan.rs
Adez017 f702ce8
added comments
Adez017 6059237
Merge branch 'main' into proto-fix
Adez017 49a58ef
Merge branch 'main' into proto-fix
Adez017 fc79af9
Update mod.rs
Adez017 4815b8f
Refactor filter execution tests for roundtrip serialization
Adez017 7cc6f90
refactor test
Adez017 33304ca
Merge branch 'main' into proto-fix
Adez017 39e43c5
Remove trailing blank line in roundtrip_physical_plan.rs
Adez017 2e0d127
Merge branch 'main' into proto-fix
Adez017 979368a
Merge branch 'main' into proto-fix
Adez017 6506eed
Merge branch 'main' into proto-fix
Adez017 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.