Skip to content

ci: use base repository branch for breaking change detector#22006

Merged
rluvaton merged 1 commit intoapache:mainfrom
rluvaton:fix-breaking-change-detector-on-forks
May 3, 2026
Merged

ci: use base repository branch for breaking change detector#22006
rluvaton merged 1 commit intoapache:mainfrom
rluvaton:fix-breaking-change-detector-on-forks

Conversation

@rluvaton
Copy link
Copy Markdown
Member

@rluvaton rluvaton commented May 3, 2026

this is fixing the issue where forks have stale target branch (stale main)

Which issue does this PR close?

Rationale for this change

Making breaking change detector work for stale repositories

What changes are included in this PR?

dont use origin as the remote but use the base repository as the origin

Are these changes tested?

manually

Are there any user-facing changes?

Nope

this is fixing the issue where forks have stale target branch (stale
main)
@github-actions github-actions Bot added the development-process Related to development process of DataFusion label May 3, 2026
@rluvaton
Copy link
Copy Markdown
Member Author

rluvaton commented May 3, 2026

@kumarUjjawal can you please review?

Copy link
Copy Markdown
Contributor

@kumarUjjawal kumarUjjawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@rluvaton rluvaton added this pull request to the merge queue May 3, 2026
Merged via the queue into apache:main with commit 1601ba3 May 3, 2026
35 checks passed
@rluvaton rluvaton deleted the fix-breaking-change-detector-on-forks branch May 3, 2026 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

development-process Related to development process of DataFusion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Breaking change detector cannot compile datafusion-common in some cases

2 participants