-
Notifications
You must be signed in to change notification settings - Fork 2.1k
feat: add array_normalize scalar function #22013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
crm26
wants to merge
1
commit into
apache:main
Choose a base branch
from
crm26:feat/array-normalize
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+389
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,207 @@ | ||
| // Licensed to the Apache Software Foundation (ASF) under one | ||
| // or more contributor license agreements. See the NOTICE file | ||
| // distributed with this work for additional information | ||
| // regarding copyright ownership. The ASF licenses this file | ||
| // to you under the Apache License, Version 2.0 (the | ||
| // "License"); you may not use this file except in compliance | ||
| // with the License. You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, | ||
| // software distributed under the License is distributed on an | ||
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| //! [`ScalarUDFImpl`] definitions for array_normalize function. | ||
|
|
||
| use crate::utils::make_scalar_function; | ||
| use arrow::array::{Array, ArrayRef, Float64Array, GenericListArray, OffsetSizeTrait}; | ||
| use arrow::buffer::{NullBuffer, OffsetBuffer}; | ||
| use arrow::datatypes::{ | ||
| DataType, | ||
| DataType::{FixedSizeList, LargeList, List, Null}, | ||
| Field, | ||
| }; | ||
| use datafusion_common::cast::{as_float64_array, as_generic_list_array}; | ||
| use datafusion_common::utils::{ListCoercion, coerced_type_with_base_type_only}; | ||
| use datafusion_common::{Result, internal_err, plan_err, utils::take_function_args}; | ||
| use datafusion_expr::{ | ||
| ColumnarValue, Documentation, ScalarFunctionArgs, ScalarUDFImpl, Signature, | ||
| Volatility, | ||
| }; | ||
| use datafusion_macros::user_doc; | ||
| use std::sync::Arc; | ||
|
|
||
| make_udf_expr_and_func!( | ||
| ArrayNormalize, | ||
| array_normalize, | ||
| array, | ||
| "returns the L2-normalized vector for a numeric array.", | ||
| array_normalize_udf | ||
| ); | ||
|
|
||
| #[user_doc( | ||
| doc_section(label = "Array Functions"), | ||
| description = "Returns the L2-normalized vector for the input numeric array, computed as `array[i] / sqrt(sum(array[i]^2))` per element. Returns NULL if the input is NULL, contains NULL elements, or has zero magnitude (all elements are zero). Returns an empty array for an empty input array.", | ||
| syntax_example = "array_normalize(array)", | ||
| sql_example = r#"```sql | ||
| > select array_normalize([3.0, 4.0]); | ||
| +-----------------------------+ | ||
| | array_normalize(List([3.0,4.0])) | | ||
| +-----------------------------+ | ||
| | [0.6, 0.8] | | ||
| +-----------------------------+ | ||
| ```"#, | ||
| argument( | ||
| name = "array", | ||
| description = "Array expression. Can be a constant, column, or function, and any combination of array operators." | ||
| ) | ||
| )] | ||
| #[derive(Debug, PartialEq, Eq, Hash)] | ||
| pub struct ArrayNormalize { | ||
| signature: Signature, | ||
| aliases: Vec<String>, | ||
| } | ||
|
|
||
| impl Default for ArrayNormalize { | ||
| fn default() -> Self { | ||
| Self::new() | ||
| } | ||
| } | ||
|
|
||
| impl ArrayNormalize { | ||
| pub fn new() -> Self { | ||
| Self { | ||
| signature: Signature::user_defined(Volatility::Immutable), | ||
| aliases: vec!["list_normalize".to_string()], | ||
| } | ||
| } | ||
| } | ||
|
|
||
| impl ScalarUDFImpl for ArrayNormalize { | ||
| fn name(&self) -> &str { | ||
| "array_normalize" | ||
| } | ||
|
|
||
| fn signature(&self) -> &Signature { | ||
| &self.signature | ||
| } | ||
|
|
||
| fn return_type(&self, arg_types: &[DataType]) -> Result<DataType> { | ||
| // After `coerce_types`, `arg_types[0]` is one of List(Float64) or LargeList(Float64). | ||
| Ok(arg_types[0].clone()) | ||
| } | ||
|
|
||
| fn coerce_types(&self, arg_types: &[DataType]) -> Result<Vec<DataType>> { | ||
| let [arg_type] = take_function_args(self.name(), arg_types)?; | ||
| let coercion = Some(&ListCoercion::FixedSizedListToList); | ||
|
|
||
| if !matches!(arg_type, Null | List(_) | LargeList(_) | FixedSizeList(..)) { | ||
| return plan_err!("{} does not support type {arg_type}", self.name()); | ||
| } | ||
|
|
||
| let coerced = if matches!(arg_type, Null) { | ||
| List(Arc::new(Field::new_list_field(DataType::Float64, true))) | ||
| } else { | ||
| coerced_type_with_base_type_only(arg_type, &DataType::Float64, coercion) | ||
| }; | ||
|
|
||
| Ok(vec![coerced]) | ||
| } | ||
|
|
||
| fn invoke_with_args(&self, args: ScalarFunctionArgs) -> Result<ColumnarValue> { | ||
| make_scalar_function(array_normalize_inner)(&args.args) | ||
| } | ||
|
|
||
| fn aliases(&self) -> &[String] { | ||
| &self.aliases | ||
| } | ||
|
|
||
| fn documentation(&self) -> Option<&Documentation> { | ||
| self.doc() | ||
| } | ||
| } | ||
|
|
||
| fn array_normalize_inner(args: &[ArrayRef]) -> Result<ArrayRef> { | ||
| let [array] = take_function_args("array_normalize", args)?; | ||
| match array.data_type() { | ||
| List(_) => general_array_normalize::<i32>(args), | ||
| LargeList(_) => general_array_normalize::<i64>(args), | ||
| arg_type => internal_err!( | ||
| "array_normalize received unexpected type after coercion: {arg_type}" | ||
| ), | ||
| } | ||
| } | ||
|
|
||
| fn general_array_normalize<O: OffsetSizeTrait>(arrays: &[ArrayRef]) -> Result<ArrayRef> { | ||
| let list_array = as_generic_list_array::<O>(&arrays[0])?; | ||
| let values = as_float64_array(list_array.values())?; | ||
| let offsets = list_array.value_offsets(); | ||
|
|
||
| let mut new_values: Vec<f64> = Vec::with_capacity(values.len()); | ||
| let mut new_offsets: Vec<O> = Vec::with_capacity(list_array.len() + 1); | ||
| new_offsets.push(O::usize_as(0)); | ||
| let mut validity: Vec<bool> = Vec::with_capacity(list_array.len()); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Use |
||
|
|
||
| for row in 0..list_array.len() { | ||
| if list_array.is_null(row) { | ||
| new_offsets.push(*new_offsets.last().unwrap()); | ||
| validity.push(false); | ||
| continue; | ||
| } | ||
|
|
||
| let start = offsets[row].as_usize(); | ||
| let end = offsets[row + 1].as_usize(); | ||
| let len = end - start; | ||
|
|
||
| let slice = values.slice(start, len); | ||
| if slice.null_count() != 0 { | ||
| new_offsets.push(*new_offsets.last().unwrap()); | ||
| validity.push(false); | ||
| continue; | ||
| } | ||
|
|
||
| let vals = slice.values(); | ||
|
|
||
| // Empty array: return empty array (no normalization needed, no division by zero risk) | ||
| if len == 0 { | ||
| new_offsets.push(*new_offsets.last().unwrap()); | ||
| validity.push(true); | ||
| continue; | ||
| } | ||
|
|
||
| // Compute squared magnitude. | ||
| let mut sq_sum = 0.0; | ||
| for i in 0..len { | ||
| sq_sum += vals[i] * vals[i]; | ||
| } | ||
|
|
||
| // Zero magnitude: undefined normalization. Emit NULL row. | ||
| if sq_sum == 0.0 { | ||
| new_offsets.push(*new_offsets.last().unwrap()); | ||
| validity.push(false); | ||
| continue; | ||
| } | ||
|
|
||
| let mag = sq_sum.sqrt(); | ||
| for i in 0..len { | ||
| new_values.push(vals[i] / mag); | ||
| } | ||
| new_offsets.push(*new_offsets.last().unwrap() + O::usize_as(len)); | ||
| validity.push(true); | ||
| } | ||
|
|
||
| let values_array = Arc::new(Float64Array::from(new_values)); | ||
| let nulls = NullBuffer::from(validity); | ||
| let field = Arc::new(Field::new_list_field(DataType::Float64, true)); | ||
|
|
||
| Ok(Arc::new(GenericListArray::<O>::try_new( | ||
| field, | ||
| OffsetBuffer::<O>::new(new_offsets.into()), | ||
| values_array, | ||
| Some(nulls), | ||
| )?)) | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,146 @@ | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
||
| ## array_normalize | ||
|
|
||
| # 3-4-5 right triangle: [3,4] / 5 = [0.6, 0.8] | ||
| query ? | ||
| select array_normalize([3.0, 4.0]); | ||
| ---- | ||
| [0.6, 0.8] | ||
|
|
||
| # Already-unit vector along axis: [1,0] -> [1,0] | ||
| query ? | ||
| select array_normalize([1.0, 0.0]); | ||
| ---- | ||
| [1.0, 0.0] | ||
|
|
||
| # 3D vector: [1,2,2] / 3 = [0.333..., 0.666..., 0.666...] | ||
| query ? | ||
| select array_normalize([1.0, 2.0, 2.0]); | ||
| ---- | ||
| [0.3333333333333333, 0.6666666666666666, 0.6666666666666666] | ||
|
|
||
| # Negative components preserved | ||
| query ? | ||
| select array_normalize([-3.0, 4.0]); | ||
| ---- | ||
| [-0.6, 0.8] | ||
|
|
||
| # Bare NULL input returns NULL | ||
| query ? | ||
| select array_normalize(NULL); | ||
| ---- | ||
| NULL | ||
|
|
||
| # NULL element inside a list returns NULL for that row | ||
| query ? | ||
| select array_normalize([1.0, NULL, 2.0]); | ||
| ---- | ||
| NULL | ||
|
|
||
| # Zero vector returns NULL (undefined normalization) | ||
| query ? | ||
| select array_normalize([0.0, 0.0]); | ||
| ---- | ||
| NULL | ||
|
|
||
| # Single non-zero component: [5] -> [1] | ||
| query ? | ||
| select array_normalize([5.0]); | ||
| ---- | ||
| [1.0] | ||
|
|
||
| # LargeList support | ||
| query ? | ||
| select array_normalize(arrow_cast([3.0, 4.0], 'LargeList(Float64)')); | ||
| ---- | ||
| [0.6, 0.8] | ||
|
|
||
| # FixedSizeList input (coerced to List) | ||
| query ? | ||
| select array_normalize(arrow_cast([3.0, 4.0], 'FixedSizeList(2, Float64)')); | ||
| ---- | ||
| [0.6, 0.8] | ||
|
|
||
| # Float32 inner type (coerced to Float64) | ||
| query ? | ||
| select array_normalize(arrow_cast([3.0, 4.0], 'List(Float32)')); | ||
| ---- | ||
| [0.6, 0.8] | ||
|
|
||
| # Int64 inner type (coerced to Float64) | ||
| query ? | ||
| select array_normalize(arrow_cast([3, 4], 'List(Int64)')); | ||
| ---- | ||
| [0.6, 0.8] | ||
|
|
||
| # Integer literals (coerced to Float64) | ||
| query ? | ||
| select array_normalize([3, 4]); | ||
| ---- | ||
| [0.6, 0.8] | ||
|
|
||
| # Unsupported non-list input (plan error) | ||
| query error array_normalize does not support type | ||
| select array_normalize(1); | ||
|
|
||
| # Multi-row query: normal row, NULL row, zero-vector row, NULL-element row | ||
| query ? | ||
| select array_normalize(column1) from (values | ||
| (make_array(3.0, 4.0)), | ||
| (NULL), | ||
| (make_array(0.0, 0.0)), | ||
| (make_array(1.0, NULL)) | ||
| ) as t(column1); | ||
| ---- | ||
| [0.6, 0.8] | ||
| NULL | ||
| NULL | ||
| NULL | ||
|
|
||
| # Empty array: returns empty array (no normalization needed, no division by zero) | ||
| query ? | ||
| select array_normalize(arrow_cast(make_array(), 'List(Float64)')); | ||
| ---- | ||
| [] | ||
|
|
||
| # No arguments error | ||
| query error array_normalize function requires 1 argument, got 0 | ||
| select array_normalize(); | ||
|
|
||
| # Return type matches input variant (List of Float64) | ||
| query ?T | ||
| select array_normalize([3.0, 4.0]), arrow_typeof(array_normalize([3.0, 4.0])); | ||
| ---- | ||
| [0.6, 0.8] List(Float64) | ||
|
|
||
| # list_normalize alias produces the same result | ||
| query ? | ||
| select list_normalize([3.0, 4.0]); | ||
| ---- | ||
| [0.6, 0.8] | ||
|
|
||
| # list_normalize alias multi-row with NULL row | ||
| query ? | ||
| select list_normalize(column1) from (values | ||
| (make_array(3.0, 4.0)), | ||
| (NULL) | ||
| ) as t(column1); | ||
| ---- | ||
| [0.6, 0.8] | ||
| NULL |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it might be simpler to use
OffsetBufferBuilderhere