feat: support binary and string types for concat UDFs#22244
Open
theirix wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
BYTEA,Binary) concatenation #12709.Rationale for this change
While #21883 introduced binary argument support for the pipe operator, this PR targets three UDFs:
concat,concat_ws, and Spark'sconcatto harmonise all their behaviour.We decided to support only string+string and binary+binary and ban mixed operations, to match the behaviour of the majority of engines. Previously, mixed behaviour was allowed in #20787.
What changes are included in this PR?
concat_wsbehavior for different separator typesThe diff is quite large. Detailed code changes:
ConcatBuilderto abstract string/binary/view/array operationsStringArray/LargeStringArrayinto a genericConcatGenericStringBuilder- less duplicationbinaries.rsColumnarValueRefvariants to handle nullable and non-nullable binary typesfrom_columnar_value- simplified call sites. Scalar code path stays mostly the sameSignature::variadictoSignature::UserDefinedto allow different argument types.Variadicrequired every argument (including binaries) to be coerced to the same string type, so the UDF cannot distinguish between binary and string inputs. It's a relatively uncommon - happy to discussconcatimplementation, so it handles only Spark-specific null-handlingspark/concat.slt) to a generic SLT, so we test both generic and Spark-specific behaviourAre these changes tested?
Are there any user-facing changes?
No