fix: align regexp_instr empty pattern#22286
Open
Sean-Kenneth-Doherty wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
regexp_instrwith an empty pattern should return 1 #22257.Rationale for this change
PostgreSQL treats an empty regular expression in
regexp_instras a zero-width match. DataFusion previously special-cased empty patterns to return0, soregexp_instr('abc', '')diverged from PostgreSQL.What changes are included in this PR?
regexp_instrpatterns as zero-width matches atstart + N - 1, returning0when that position is past the end of the string.Are these changes tested?
cargo fmt --allcargo test -p datafusion-functions regex::regexpinstr::tests::test_regexp_instr -- --nocapturecargo test --profile=ci --test sqllogictests -- regexp/regexp_instr.sltTMPDIR=/home/sean/Projects/datafusion-contrib/target/tmp cargo clippy --all-targets --all-features -- -D warningsgit diff --checkAre there any user-facing changes?
Yes.
regexp_instrnow matches PostgreSQL behavior for empty regular expression patterns.