test: cover regexp_replace multiline flag#22287
Open
Sean-Kenneth-Doherty wants to merge 1 commit into
Open
Conversation
Author
|
Fresh validation on the PR head (
GitHub Actions only ran the labeler for this PR, so this leaves current regression evidence visible for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
regexp_replaceshould honor PostgreSQL multiline flagm#22258.Rationale for this change
PostgreSQL-compatible
regexp_replaceshould honor the multiline flagmso anchors like^can match after newlines. The issue report coversregexp_replace(E'a\nb', '^b', 'x', 'm'), which should producea\nx.Current main already returns the PostgreSQL-compatible result, so this PR adds explicit regression coverage to keep that behavior from drifting.
What changes are included in this PR?
regexp_replacewith flagm.mandgmmultiline flag behavior.Are these changes tested?
cargo fmt --allTMPDIR=/home/sean/Projects/datafusion-regexp-replace/target/tmp cargo test -p datafusion-functions regex::regexpreplace::tests::test_static_pattern_regexp_replace_multiline_flag -- --nocaptureTMPDIR=/home/sean/Projects/datafusion-regexp-replace/target/tmp cargo test --profile=ci --test sqllogictests -- regexp/regexp_replace.sltTMPDIR=/home/sean/Projects/datafusion-regexp-replace/target/tmp cargo clippy --all-targets --all-features -- -D warningsgit diff --checkAre there any user-facing changes?
No behavior change intended. This adds regression coverage for PostgreSQL-compatible multiline
regexp_replacebehavior.