Extract parquet push decoder module#22289
Merged
adriangb merged 4 commits intoMay 17, 2026
Merged
Conversation
Member
Author
|
All looks good to me, so I don't make any changes for your commits. haha cc @adriangb |
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
This decouples the helper from opener.rs internals: it now takes its inputs directly (predicate, schema, metadata, reorder flag, metrics) rather than a `&PreparedParquetOpen`, so it lives alongside the underlying `build_row_filter` it wraps. opener.rs constructs it from the prepared state. No behavior change.
Move the configuration struct and its builder construction out of opener.rs into a new `push_decoder` module. The helper becomes a `build(prepared_access_plan, metadata)` method on the config, which reads more naturally at the call site. No behavior change.
Co-locate the per-file stream driver with the builder configuration it consumes. Add `into_stream` so the opener doesn't need to name the unfold/fuse type; it just hands off the state and gets back a `BoxStream`. After this commit, push_decoder.rs owns the full push-decoder lifecycle (builder setup + stream driving), and build_stream in opener.rs reads as orchestration: prepare access plans, build decoders, hand off to the stream, optionally wrap in EarlyStoppingStream. No behavior change.
adriangb
force-pushed
the
xudong963/extract-push-decoder-module
branch
from
88ad15f to
960a9fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow-up to #22191.
Rationale for this change
This is a code organization follow-up suggested during review of #22191. The push decoder setup and stream-driving state now live outside
opener.rs, making the opener focus on orchestration.What changes are included in this PR?
RowFilterGeneratortorow_filter.rs, next tobuild_row_filter.push_decoder.rsforDecoderBuilderConfigandPushDecoderStreamState.mod.rs.No behavior change intended.
Are these changes tested?
Existing tests cover the behavior.
Are there any user-facing changes?
No. This is an internal refactor.