fix: guard array_position start_from underflow#22291
Open
Sean-Kenneth-Doherty wants to merge 1 commit into
Open
fix: guard array_position start_from underflow#22291Sean-Kenneth-Doherty wants to merge 1 commit into
Sean-Kenneth-Doherty wants to merge 1 commit into
Conversation
Author
|
Fresh validation on the PR head (
GitHub Actions only ran the labeler for this PR, so this keeps the regression evidence visible while the branch waits for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
array_positionconverts the optional 1-indexedstart_fromargument to a 0-indexed offset by subtracting one. Whenstart_fromisi64::MIN, that subtraction can underflow and panic before DataFusion can return a normal error.What changes are included in this PR?
array_positionstart_fromvalues.start_frompaths.i64::MINboundary.Are these changes tested?
cargo fmt --allTMPDIR=/home/sean/Projects/datafusion-array-position-min/target/tmp cargo test -p datafusion-functions-nested position::tests::test_array_position_start_from_min_value -- --nocaptureTMPDIR=/home/sean/Projects/datafusion-array-position-min/target/tmp cargo test --profile=ci --test sqllogictests -- array/array_position.sltTMPDIR=/home/sean/Projects/datafusion-array-position-min/target/tmp cargo clippy --all-targets --all-features -- -D warningsgit diff --checkI also manually checked the issue reproducer no longer panics:
EXPLAIN SELECT array_position([1], 1, -9223372036854775808);now returns a plan, while plain execution returnsExecution error: start_from out of bounds: -9223372036854775808.Are there any user-facing changes?
Invalid
array_positionstart_fromvalues at thei64::MINboundary now return a normal DataFusion error instead of panicking.