fix: return NULL for negative array subscripts in PostgreSQL dialect#22294
Open
leno23 wants to merge 1 commit into
Open
fix: return NULL for negative array subscripts in PostgreSQL dialect#22294leno23 wants to merge 1 commit into
leno23 wants to merge 1 commit into
Conversation
When `sql_parser.dialect` is PostgreSQL, `array_element` no longer treats negative indexes as end-relative; out-of-range negative subscripts yield NULL to match PostgreSQL. Fixes apache#22254. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #22254.
Rationale for this change
PostgreSQL returns
NULLfor expressions like(array[10,20,30])[-1], while DataFusion previously treated negative subscripts as end-relative indexing (returning30).What changes are included in this PR?
datafusion.sql_parser.dialectispostgresql,array_elementreturns NULL for negative indexes instead of counting from the endAre these changes tested?
cargo test -p datafusion-functions-nested test_array_elementAre there any user-facing changes?
Yes. With PostgreSQL dialect configured, negative array subscripts now match PostgreSQL semantics.
Made with Cursor