Guard array_repeat list overflow#22295
Open
Sean-Kenneth-Doherty wants to merge 1 commit into
Open
Conversation
Author
|
Fresh local validation on
The GitHub |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
array_repeatcan panic for list inputs when it precomputes the repeated inner value count withlen * count. A very large count can overflow that multiplication before DataFusion has a chance to return a normal execution error.What changes are included in this PR?
array_repeat.array_repeat([1, 2, 3], 9223372036854775807).Scope note: this intentionally targets the list-input path from #22219. The scalar element path is separate from this issue.
Are these changes tested?
Yes.
cargo test -p datafusion-functions-nested list_repeat_rejects_inner_count_overflowcargo test -p datafusion-sqllogictest --test sqllogictests -- array/array_repeat.sltcargo test -p datafusion-functions-nestedcargo fmt --checkcargo clippy -p datafusion-functions-nested --all-targets -- -D warningsgit diff --checkAre there any user-facing changes?
Yes. A malformed/oversized
array_repeatquery now returns a DataFusion execution error instead of panicking the process.