Guard insert placeholder zero#22299
Open
Sean-Kenneth-Doherty wants to merge 1 commit into
Open
Conversation
Author
|
Local validation on current head (
The local checkout is clean after validation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Fixes #22224.
Rationale for this change
EXPLAIN INSERT INTO t VALUES ($0)currently panics while inferring parameter types for INSERT VALUES. Other SQL paths already reject$0as an invalid placeholder index, and the INSERT inference path should do the same instead of subtracting one from zero.What changes are included in this PR?
EXPLAIN INSERT INTO ... VALUES ($0).Are these changes tested?
Yes.
cargo fmt --check --allcargo test -p datafusion-sqllogictest --test sqllogictests -- insert_values_placeholderscargo test -p datafusion-sql --test sql_integration test_insert_schema_errors-> 6 passedgit diff --check origin/main...HEADgit diff --cached --checkAre there any user-facing changes?
Yes.
INSERT ... VALUES ($0)now returns a planning error instead of panicking.Scope note
The change is limited to INSERT VALUES placeholder type inference and the new regression coverage. I did not find any broader placeholder semantics that needed to change.