Guard runtime SET UTF-8 suffix parsing#22301
Open
Sean-Kenneth-Doherty wants to merge 1 commit into
Open
Conversation
Author
|
Validated head df3afaa locally. The patch targets the old byte-index slicing path, and the regression now returns normal planning errors for non-ASCII suffixes instead of panicking. Commands run:
Working tree remained clean after validation. Hosted checks currently show the labeler |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Runtime
SET datafusion.runtime.*parsing split the last byte off capacity and duration values withsplit_at(value.len() - 1). For values ending in a multi-byte UTF-8 character, that byte index can fall inside the final character and panic before DataFusion can return a planner error.What changes are included in this PR?
Are these changes tested?
Yes.
cargo test -p datafusion --lib test_parse_cargo test -p datafusion --test core_integration test_runtime_config_non_ascii_suffix_returns_errorcargo fmt --checkcargo clippy -p datafusion --lib --test core_integration -- -D warningsgit diff --checkAre there any user-facing changes?
Yes. Malformed runtime config values ending in non-ASCII characters now return planner errors instead of panicking.
Scope note
The change is limited to avoiding byte-boundary panics while preserving the existing parser/error paths for malformed runtime config values.