Guard to_timestamp decimal overflow#22307
Merged
Jefffrey merged 1 commit intoMay 25, 2026
Merged
Conversation
kosiew
approved these changes
May 23, 2026
kosiew
left a comment
Contributor
There was a problem hiding this comment.
@Sean-Kenneth-Doherty
Thanks for the fix
Looks 👍 to me
Jefffrey
approved these changes
May 25, 2026
Contributor
|
Thanks @Sean-Kenneth-Doherty & @kosiew |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
to_timestampconverted Decimal128 inputs to nanoseconds with uncheckedi128multiplication followed by anas i64cast. Large Decimal128 values could overflow during nanosecond scaling, causing a panic in debug builds or a wrapped timestamp value in release builds.What changes are included in this PR?
Are these changes tested?
cargo fmt --checkgit diff --checkCARGO_TARGET_DIR=/home/sean/Projects/datafusion-runtime-set-nonascii/target CARGO_BUILD_JOBS=2 cargo test -p datafusion-functions --lib to_timestamp_decimal128CARGO_TARGET_DIR=/home/sean/Projects/datafusion-runtime-set-nonascii/target CARGO_BUILD_JOBS=2 cargo clippy -p datafusion-functions --lib -- -D warnings