Port NotExpr proto hooks#22463
Open
Herrtian wants to merge 4 commits into
Open
Conversation
github-actions
Bot
added
physical-expr
Contributor
|
@Herrtian Thank you for picking this up. Can you please update the PR body with more details. Use the pr template for this. |
Author
|
Updated the PR body to use the template. |
Contributor
|
@Herrtian we should add a direct test for the new hook code itself, especially the bad-input case like a missing child expression. |
Author
|
Added a direct missing-child test for the NotExpr proto hook. Checked with:
|
|
|
||
| let protobuf::PhysicalNot { expr } = match &node.expr_type { | ||
| Some(protobuf::physical_expr_node::ExprType::NotExpr(e)) => e.as_ref(), | ||
| _ => return internal_err!("PhysicalExprNode is not a NotExpr"), |
Contributor
There was a problem hiding this comment.
should surface both expr_id and the actual expr_type variant the decoder received.
| _ => return internal_err!("PhysicalExprNode is not a NotExpr"), | ||
| }; | ||
| let expr = expr.as_deref().ok_or_else(|| { | ||
| datafusion_common::DataFusionError::Internal( |
Contributor
There was a problem hiding this comment.
we should use internal_datafusion_err!
Author
|
Addressed the review comments: the missing-child path now uses Checked with:
|
Signed-off-by: Herrtian <70463940+Herrtian@users.noreply.github.com>
Signed-off-by: Herrtian <70463940+Herrtian@users.noreply.github.com>
Herrtian
force-pushed
the
port-notexpr-proto-hooks
branch
from
d7ad593 to
33a90db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
NotExprto usetry_to_proto/try_from_proto#22422.Rationale for this change
NotExprstill used the central physical expression protobuf downcast path. Moving it to the expression-level proto hook keeps it aligned with the newer serialization pattern and reduces the special-case branching in the shared conversion code.What changes are included in this PR?
NotExprprotobuf serialization into itstry_to_protohook.NotExpr::try_from_protoand route decode through it.to_protodowncast branch forNotExpr.Are these changes tested?
Yes. I ran:
cargo fmt --all -- --checkcargo check -p datafusion-physical-expr --features protocargo check -p datafusion-protocargo test -p datafusion-proto --test proto_integration roundtrip_filter_with_notgit diff --checkAre there any user-facing changes?
No. This is an internal proto serialization refactor and should not change query behavior or public APIs.