Skip to content

minor: Make union_with_mix_of_presorted_and_explicitly_resorted_inputs_impl cross platform #22478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nuno-faria wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −1
Open

minor: Make union_with_mix_of_presorted_and_explicitly_resorted_inputs_impl cross platform #22478

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion datafusion/core/tests/dataframe/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3345,7 +3345,11 @@ async fn union_with_mix_of_presorted_and_explicitly_resorted_inputs_impl(

// To be able to remove user specific paths from the plan, for stable assertions
let testdata_clean = Path::new(&testdata).canonicalize()?.display().to_string();
let testdata_clean = testdata_clean.strip_prefix("/").unwrap_or(&testdata_clean);
let testdata_clean = testdata_clean.replace("\\", "/");
let testdata_clean = testdata_clean
.strip_prefix("//?/")
.or_else(|| testdata_clean.strip_prefix("/"))
.unwrap_or(&testdata_clean);

// Use displayable() rather than explain().collect() to avoid table formatting issues. We need
// to replace machine-specific paths with variable lengths, which breaks table alignment and
Expand Down