fix: reborrow metadata values when intersecting union metadata#22491
Open
officialasishkumar wants to merge 1 commit into
Open
fix: reborrow metadata values when intersecting union metadata#22491officialasishkumar wants to merge 1 commit into
officialasishkumar wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
intersect_metadata_for_unioncompares values retained byHashMap::retainwith values from another metadata map. The retained value is passed as&mut String, which can makeOptionequality ambiguous for downstream crates when additional blanketPartialEqimplementations are in scope.Reborrowing the retained value as
&Stringkeeps the comparison type explicit without changing behavior.What changes are included in this PR?
The metadata retain predicate now compares
metadata.get(k)withSome(&*v)instead ofSome(v).Are these changes tested?
Yes.
cargo test -p datafusion-expr intersect_metadata_testscargo fmt --all -- --checkgit diff --checkAre there any user-facing changes?
No runtime behavior change. This avoids a downstream compilation failure in the reported dependency configuration.