feat: Improve display of Decimal values#22500
Open
neilconway wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
DisplayofDecimalvalues #22485.Rationale for this change
Displaying
Decimalvalues (e.g., inEXPLAINoutput or in auto-generated column names) included Rust'sSomenotation. For example:Eliding the rest of the
EXPLAINoutput, the projection is rendered as asDecimal128(Some(1),1,1): Some(1),1,1.This is not very readable:
OptionsyntaxNone, we should printNULL, so showing theOptionis not useful anyway1) into the actual value (0.1)This PR changes how
Decimalvalues are displayed. For example, the query above would show the projection as:Decimal128(0.1,1,1): 0.1.What changes are included in this PR?
fmt::Displayandfmt::DebugforScalarValueto use the new format forDecimalvaluesfmt_binarytofmt_binary_debugfor consistency (this format is used byDebug, notDisplay)Are these changes tested?
Yes; new tests added and expected test output has been updated. The implemented behavior was compared with Postgres and DuckDB, and roughly matches what those other systems do.
Are there any user-facing changes?
Yes. This change may break users that have
EXPLAINoutput or auto-generated column names in golden files, and other places where theDebug/Displayof aScalarValueis being compared against. A section has been added to the 55.0.0 migration guide.