refactor: Port IsNullExpr proto serialization hooks#22509
Open
chakkk309 wants to merge 1 commit into
Open
Conversation
2f3448a to
74e4190
Compare
74e4190 to
ff682e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
IsNullExprto usetry_to_proto/try_from_proto#22423.Rationale for this change
This is part of #22418, which migrates built-in
PhysicalExprimplementations away from the central protobuf serialization / deserialization chains.IsNullExprcan now own its protobuf serialization throughPhysicalExpr::try_to_protoand its deserialization throughIsNullExpr::try_from_proto, matching the pattern introduced forColumnandBinaryExpr.What changes are included in this PR?
PhysicalExpr::try_to_protosupport forIsNullExpr.IsNullExpr::try_from_proto.IsNullExprdeserialization infrom_proto.rsthrough the new hook.IsNullExprserialization branch from the centralto_proto.rsdowncast chain.IsNullExprroundtripAre these changes tested?
Yes.
I ran: