fix: reject negative logarithm inputs#22738
Closed
puneetdixit200 wants to merge 1 commit into
Closed
Conversation
Contributor
|
@puneetdixit200 Isn't this the same PR you opened previously which already had another PR. I would appreciate it if you look at the linked pr in the issue before opening a new one. |
Contributor
Author
|
Closing this as a duplicate of #22276. I missed the existing linked PR when reopening this scope; sorry for the noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
ln(-1.0::float8)should error, not return NaN #22271.Rationale for this change
PostgreSQL-compatible logarithm behavior should reject negative inputs instead of returning
NaN. DataFusion already keeps the existing zero/base-one edge cases, so this change is scoped to negative logarithm arguments.What changes are included in this PR?
ln,log2, andlog10.log(...)for float and decimal inputs.Are these changes tested?
cargo fmt --allcargo test -p datafusion-functions log --libcargo test --profile=ci --test sqllogictests -- scalar.sltcargo clippy --all-targets --all-features -- -D warningsAre there any user-facing changes?
Yes. Negative logarithm inputs now return a domain error instead of
NaN.