Skip to content

Commit 4778e3a

Browse files
authored
Merge pull request #360 from apache/359-use-non-colliding-family-id-in-count-min
Changed family id to 18
2 parents 034749f + 3a6f2df commit 4778e3a

2 files changed

Lines changed: 4 additions & 5 deletions

File tree

count/include/count_min.hpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -319,8 +319,7 @@ class count_min_sketch{
319319
static const uint8_t PREAMBLE_LONGS_SHORT = 2; // Empty -> need second byte for sketch parameters
320320
static const uint8_t PREAMBLE_LONGS_FULL = 3; // Not empty -> need (at least) third byte for total weight.
321321
static const uint8_t SERIAL_VERSION_1 = 1;
322-
static const uint8_t FAMILY_ID = 1;
323-
//static const size_t DATA_START = 24;
322+
static const uint8_t FAMILY_ID = 18;
324323
static const uint8_t NULL_8 = 0;
325324
static const uint32_t NULL_32 = 0;
326325

count/include/count_min_impl.hpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -491,9 +491,9 @@ void count_min_sketch<W,A>::check_header_validity(uint8_t preamble_longs, uint8_
491491
bool valid = true;
492492

493493
switch (sw) { // exhaustive list and description of all valid cases
494-
case 70 : break; // !empty, ser_ver==1, family==1, preLongs=2;
495-
case 71 : break; // empty, ser_ver==1, family==1, preLongs=2;
496-
//case 102 : break ; // !empty, ser_ver==1, family==1, preLongs=3 ;
494+
case 138 : break; // !empty, ser_ver==1, family==18, preLongs=2;
495+
case 139 : break; // empty, ser_ver==1, family==18, preLongs=2;
496+
//case 170 : break ; // !empty, ser_ver==1, family==18, preLongs=3 ;
497497
default : // all other case values are invalid
498498
valid = false;
499499
}

0 commit comments

Comments
 (0)