Fix to string

Author: geonove

ddsketch/include/ddsketch.hpp

@@ -61,7 +61,7 @@ class  DDSketch {
   static DDSketch deserialize(std::istream& is);
   int get_serialized_size_bytes() const;
 
-  template<class A>
+  template<class A = std::allocator<char>>
   string<A> to_string() const;
   bool operator==(const DDSketch<Store, Mapping>& other) const;
 protected:

ddsketch/include/ddsketch_impl.hpp

@@ -252,13 +252,14 @@ template<class A>
 string<A> DDSketch<Store, Mapping>::to_string() const {
   std::ostringstream os;
   os << "### ddsketch summary:" << std::endl;
-  os << "   Index mapping  :" << std::endl;
-  os << index_mapping.to_string() << std::endl;
-  os << "   Positive store :" << std::endl;
-  os << positive_store.to_string() << std::endl;
-  os << "   Negative store :" << std::endl;
-  os << negative_store.to_string() << std::endl;
-  os << "   Zero count     :" <<  zero_count << std::endl;
+  os << "   Index mapping         " << std::endl;
+  os << index_mapping.to_string();
+  os << "   Positive store        " << std::endl;
+  os << positive_store.to_string();
+  os << "   Negative store        " << std::endl;
+  os << negative_store.to_string();
+  os << "   Zero count             " <<  zero_count << std::endl;
+  os << "### End ddsketch summary" << std::endl;
   return os.str();
 
 }

ddsketch/include/dense_store_impl.hpp

@@ -447,10 +447,10 @@ int DenseStore<Derived, Allocator>::get_serialized_size_bytes_common() const {
 template<class Derived, typename Allocator>
 string<Allocator> DenseStore<Derived, Allocator>::to_string() const {
   std::ostringstream os;
-  os << "      Type        : dense store " << std::endl;
-  os << "      Bins number : " << bins.size() << std::endl;
-  os << "      Min index   : " << min_index << std::endl;
-  os << "      Max index   : " << max_index << std::endl;
+  os << "      Type              : dense store " << std::endl;
+  os << "      Bins number       :" << bins.size() << std::endl;
+  os << "      Min index         :" << min_index << std::endl;
+  os << "      Max index         :" << max_index << std::endl;
   return os.str();
 }
 }

ddsketch/include/log_like_index_mapping.hpp

@@ -40,7 +40,7 @@ class LogLikeIndexMapping : public IndexMapping<Derived> {
   double max_indexable_value() const;
   void serialize(std::ostream& os) const;
 
-  template<class A>
+  template<class A = std::allocator<char>>
   string<A> to_string() const;
 
   bool operator==(const LogLikeIndexMapping<Derived>& other) const;

ddsketch/include/sparse_store_impl.hpp

@@ -232,8 +232,8 @@ int SparseStore<Allocator>::get_serialized_size_bytes() const {
 template<typename Allocator>
 string<Allocator> SparseStore<Allocator>::to_string() const {
   std::ostringstream os;
-  os << "      Type        : sparse store" << std::endl;
-  os << "      Bins number : " << bins.size() << std::endl;
+  os << "      Type              : sparse store" << std::endl;
+  os << "      Bins number       : " << bins.size() << std::endl;
   return os.str();
 }
 

ddsketch/test/DDSketchTest.cpp

@@ -581,5 +581,7 @@ TEST_CASE("quantile", "[ddsketch]") {
 
   // std::cout << ddsketch.get_quantile(0.5) << std::endl;
   // std::cout << ddsketch.get_rank(4) << std::endl;
+
+  std::cout << ddsketch.to_string();
 }
 } /* namespace datasketches */