Skip to content

Commit 90302c4

Browse files
chore: remove unused pgsql configuration from Helm chart values (#364)
### Summary This PR removes the commented `pgsql` configuration block from the Helm chart `values.yaml`. ### Motivation The chart currently exposes commented PostgreSQL configuration that appears to suggest PostgreSQL is supported, but: - The chart only implements MySQL configuration paths. - The `pgsql` values are not wired into templates. - Setting `option.database=pgsql` does not produce a working deployment. This creates confusion for users and leads to time spent attempting to configure an unsupported path. ### Change - Removes the commented `pgsql` configuration block from values.yaml. - Leaves MySQL as the clearly supported database option. ### Benefit - Reduces ambiguity around supported database backends. - Prevents users from attempting a non-functional configuration. - Improves chart clarity and maintainability. If/when PostgreSQL support becomes fully implemented, the configuration can be reintroduced with complete wiring and documentation. Happy to help reintroduce when full support exists.
1 parent ad032f2 commit 90302c4

2 files changed

Lines changed: 0 additions & 53 deletions

File tree

charts/devlake/templates/secrets.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,6 @@ stringData:
2424
{{- if (eq .Values.option.database "mysql") }}
2525
MYSQL_PASSWORD: "{{ .Values.mysql.password }}"
2626
MYSQL_ROOT_PASSWORD: "{{ .Values.mysql.rootPassword }}"
27-
#{{- else if (eq .Values.option.database "pgsql")}}
28-
# POSTGRES_PASSWORD: "{{ .Values.pgsql.password }}"
2927
{{- end }}
3028
{{- end }}
3129

charts/devlake/values.yaml

Lines changed: 0 additions & 51 deletions
Original file line numberDiff line numberDiff line change
@@ -127,57 +127,6 @@ mysql:
127127
loadBalancerIP: ""
128128
extraLabels: {}
129129

130-
# pgsql:
131-
# # if use external pgsql server, please set true
132-
# # by default using false, chart will create a single pgsql instance
133-
# useExternal: false
134-
135-
# # the external pgsql server address
136-
# externalServer: 127.0.0.1
137-
138-
# # external pgsql port
139-
# externalPort: 5432
140-
# # the username for devlake database
141-
# username: merico
142-
143-
# # the password for devlake database
144-
# password: merico
145-
146-
# # the database for devlake
147-
# database: lake
148-
149-
# # storage for pgsql
150-
# storage:
151-
# # the storage class for pv, leave empty will using default
152-
# class: ""
153-
# size: 5Gi
154-
155-
# # image for pgsql
156-
# image:
157-
# repository: postgres
158-
# tag: 14.5
159-
# pullPolicy: IfNotPresent
160-
161-
# # resources config for pgsql if have
162-
# resources: {}
163-
164-
# # nodeSelector config for pgsql if have
165-
# nodeSelector: {}
166-
167-
# # tolerations config for pgsql if have
168-
# tolerations: []
169-
170-
# # affinity config for pgsql if have
171-
# affinity: {}
172-
173-
# extraLabels: {}
174-
175-
# securityContext: {}
176-
177-
# containerSecurityContext: {}
178-
179-
# annotations: {}
180-
181130
# dependency chart values
182131
grafana:
183132
enabled: true

0 commit comments

Comments
 (0)