Enabled replicaCount

[angelsanchezdck]

Enables the ability to set replicas of StatefulSet and deployments to 0, fully disabling the devlake-helm-chart. This ensures compliance with the requirement of having only one replica for deployments in dev-lake, providing finer control over the development environment.

Issue: #266

[ZhangNing10]

hi @angelsanchezdck , thanks for creating the pr!
Different deployments/statefulset uses different values, for example .Values.lake.replicaCount. Then you can delete the values.replicaCount part in values.yaml

[angelsanchezdck]

Hi @ZhangNing10 , Done!

ui: No limit
dev-lake and mysql: replicaCount is limited to 0 or 1

[ZhangNing10]

LGTM

[ZhangNing10]

hi @angelsanchezdck , thanks a lot! could you kindly fix the conflict?

[angelsanchezdck]

Sorry for late.

[angelsanchezdck]

What is the next step?

[ZhangNing10]

hi @angelsanchezdck , action failed https://github.com/apache/incubator-devlake-helm-chart/actions/runs/11077517151/job/30834582938?pr=269 , could you check and fix it?

[ZhangNing10]

hi @angelsanchezdck , the imageTag should not be changed, kindly keep the same as main branch

[angelsanchezdck]

Hi @ZhangNing10

errors were fixed

Thank

[klesh]

Hi, @matrixji @JorgeGar . Would you kindly help reviewing this PR when you find time? Thanks.

[JorgeGar]

Hey, given the situation this solution looks good to me. Thanks @angelsanchezdck for bringing this up!

[angel-sanchez-r2]

Thank!

[klesh]

I would like to highlight that the devlake service should NOT have multiple instance, only 1 instance is allowed to connect to the same database.
Allowing specifying multiple replicas doesn't make sense to me.

[angel-sanchez-r2]

Ok, I understand.

If you look at the condition {{ if gt (int .Values.lake.replicaCount) 1 }}1{{ else }}{{ .Values.lake.replicaCount }}{{ end }}, it never allows more than 1 replica to be set.

I would also prefer if it allowed setting the replica count to 0.

[klesh]

Ok, I understand.

If you look at the condition {{ if gt (int .Values.lake.replicaCount) 1 }}1{{ else }}{{ .Values.lake.replicaCount }}{{ end }}, it never allows more than 1 replica to be set.

I would also prefer if it allowed setting the replica count to 0.

Thanks for the explanation.
In this case, I think it is OK.

Thanks for your contribution.

done

[angel-sanchez-r2]

Ty.
Waiting for release. 👏