Skip to content

Commit 99d3ef5

Browse files
authored
CI: fix ruff lint and bulk ci error (#170)
* fix error of ruff latest version * tmp disable dead link check * remove py 3.9 support * use 3.10 build doc
1 parent 5e64519 commit 99d3ef5

56 files changed

Lines changed: 69 additions & 31 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.github/workflows/ci.yaml

Lines changed: 16 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -40,17 +40,17 @@ jobs:
4040
runs-on: ubuntu-latest
4141
steps:
4242
- uses: apache/skywalking-eyes/header@main
43-
dead-link:
44-
runs-on: ubuntu-latest
45-
needs: license
46-
timeout-minutes: 30
47-
steps:
48-
- uses: actions/checkout@v3
49-
- run: sudo npm install -g markdown-link-check@3.10.0
50-
- run: |
51-
for file in $(find . -name "*.md"); do
52-
markdown-link-check -c .dlc.json -q "$file"
53-
done
43+
# dead-link:
44+
# runs-on: ubuntu-latest
45+
# needs: license
46+
# timeout-minutes: 30
47+
# steps:
48+
# - uses: actions/checkout@v3
49+
# - run: sudo npm install -g markdown-link-check@3.10.0
50+
# - run: |
51+
# for file in $(find . -name "*.md"); do
52+
# markdown-link-check -c .dlc.json -q "$file"
53+
# done
5454
lint:
5555
timeout-minutes: 15
5656
runs-on: ubuntu-latest
@@ -76,7 +76,7 @@ jobs:
7676
matrix:
7777
# YAML parse `3.10` to `3.1`, so we have to add quotes for `'3.10'`, see also:
7878
# https://github.com/actions/setup-python/issues/160#issuecomment-724485470
79-
python-version: ['3.9', '3.10', '3.11', '3.12', '3.13']
79+
python-version: ['3.10', '3.11', '3.12', '3.13']
8080
os: [ubuntu-latest, macOS-latest, windows-latest]
8181
exclude:
8282
# Skip because dependence [py4j](https://pypi.org/project/py4j/) not work on those environments
@@ -86,13 +86,6 @@ jobs:
8686
python-version: '3.11'
8787
- os: windows-latest
8888
python-version: '3.12'
89-
# Python 3.9 is on macos-13 but not macos-latest (macos-14-arm64)
90-
# https://github.com/actions/setup-python/issues/696#issuecomment-1637587760
91-
- os: macos-latest
92-
python-version: '3.9'
93-
include:
94-
- python-version: '3.9'
95-
os: macos-13
9689
steps:
9790
- uses: actions/checkout@v3
9891
- name: Set up Python ${{ matrix.python-version }}
@@ -133,7 +126,7 @@ jobs:
133126
- name: Set up Python
134127
uses: actions/setup-python@v4
135128
with:
136-
python-version: 3.11
129+
python-version: '3.10'
137130
- name: Install Dependences
138131
run: |
139132
python -m pip install --upgrade ${{ env.DEPENDENCES }}
@@ -218,15 +211,15 @@ jobs:
218211
name: CI
219212
if: always()
220213
needs:
221-
- dead-link
214+
# - dead-link
222215
- local-ci
223216
- integrate-test
224217
runs-on: ubuntu-latest
225218
steps:
226219
- name: Status
220+
# if [[ ${{ needs.dead-link.result }} != 'success' ]] || \
227221
run: |
228-
if [[ ${{ needs.dead-link.result }} != 'success' ]] || \
229-
[[ ${{ needs.local-ci.result }} != 'success' ]] || \
222+
if [[ ${{ needs.local-ci.result }} != 'success' ]] || \
230223
([[ ${{ needs.integrate-test.result }} != 'skipped' ]] && [[ ${{ needs.integrate-test.result }} != 'success' ]]); then
231224
echo "CI Failed!"
232225
exit -1

setup.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
# under the License.
1717

1818
"""The script for setting up pydolphinscheduler."""
19+
1920
from __future__ import annotations
2021

2122
import logging

src/pydolphinscheduler/configuration.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
# under the License.
1717

1818
"""Configuration module for pydolphinscheduler."""
19+
1920
import logging
2021
import os
2122
from pathlib import Path

src/pydolphinscheduler/examples/task_dependent_example.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@
3535
3636
task_dependent(this task dependent on task_dependent_external.task_1 and task_dependent_external.task_2).
3737
"""
38+
3839
from pydolphinscheduler import configuration
3940
from pydolphinscheduler.core.workflow import Workflow
4041
from pydolphinscheduler.tasks.dependent import And, Dependent, DependentItem, Or

src/pydolphinscheduler/examples/task_sagemaker_example.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717

1818
# [start workflow_declare]
1919
"""A example workflow for task sagemaker."""
20+
2021
import json
2122

2223
from pydolphinscheduler.core.workflow import Workflow

src/pydolphinscheduler/examples/task_sql_example.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
# [start workflow_declare]
1919

2020
"""A example workflow for task SQL."""
21+
2122
from pathlib import Path
2223

2324
from pydolphinscheduler.core.workflow import Workflow

src/pydolphinscheduler/examples/task_sub_workflow_example.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@
2626
from pydolphinscheduler.tasks.sub_workflow import SubWorkflow
2727
from pydolphinscheduler.tasks.shell import Shell
2828

29-
3029
# [start workflow_declare]
3130
# [start sub_workflow_declare]
3231
with Workflow(name="sub_workflow_downstream") as wf_downstream, Workflow(

src/pydolphinscheduler/examples/tutorial_resource_plugin.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
2323
it will instantiate and run all the task it have.
2424
"""
25+
2526
import os
2627
from pathlib import Path
2728

src/pydolphinscheduler/java_gateway.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
# under the License.
1717

1818
"""Module java gateway, contain gateway behavior."""
19+
1920
from __future__ import annotations
2021

2122
import contextlib

src/pydolphinscheduler/models/datasource.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
# under the License.
1717

1818
"""Module database."""
19+
1920
from __future__ import annotations
2021

2122
import json

0 commit comments

Comments
 (0)