[Improvement-18056] Clean up unused methods and classes in the dolphinschudler-api module#18134
Merged
SbloodyS merged 6 commits intoapache:devfrom Apr 7, 2026
Merged
Conversation
njnu-seafish
changed the title
SbloodyS
requested changes
Apr 6, 2026
Comment on lines
+31
to
+33
| @Data | ||
| @AllArgsConstructor | ||
| @NoArgsConstructor |
Member
There was a problem hiding this comment.
These modifications belong to the optimization class, not to remove unnecessary code. Please do not submit content unrelated to this issue.
Contributor
Author
There was a problem hiding this comment.
These modifications belong to the optimization class, not to remove unnecessary code. Please do not submit content unrelated to this issue.
I spent some time during the holiday simplifying some obvious redundant code. Alright, if this doesn't belong here, I'll go ahead and retract it.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was this PR generated or assisted by AI?
NO
Purpose of the pull request
Part of #18056
Brief change log
Clean up unused methods in the dolphinschudler-api module
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contains incompatible change, you should also add it to
docs/docs/en/guide/upgrade/incompatible.md