You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Throw exception when commit unsuccessfully. And change the exception from NonFatal to Fatal exception to make spark application throw Fatal exception and make the job failed eventually.
Checklist(Required)
Does it affect the original behavior: (Yes)
Has unit tests been added: (No Need)
Has document been added or modified: (No Need)
Does it need to update dependencies: (No)
Are there any changes that cannot be rolled back: (No)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...
Here we should just check whether the status of commit and abort is success?
Spark class ListenerBus( line 127) will not throw exception when it check the exception is NonFatal exception. So we should change the exception to Fatal exception.
Here we should just check whether the status of commit and abort is success?
Spark class ListenerBus( line 127) will not throw exception when it check the exception is NonFatal exception. So we should change the exception to Fatal exception.
Does this mean that even if commit throws an exception, the spark program will not exit?
Here we should just check whether the status of commit and abort is success?
Spark class ListenerBus( line 127) will not throw exception when it check the exception is NonFatal exception. So we should change the exception to Fatal exception.
Does this mean that even if commit throws an exception, the spark program will not exit?
Yep. Spark ListenerBus will check whether the exception is fatal or not . If the exception is not fatal the spark program only prints some warn logs and the status of the program is success.
@zhaorongsheng Thanks for reply, But I tried it locally, after commit throws an exception, it will go to abort, and then the spark task will stop. Can you provide a case that can be reproduced?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #205
Problem Summary:
Throw exception when commit unsuccessfully. And change the exception from NonFatal to Fatal exception to make spark application throw Fatal exception and make the job failed eventually.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...