Skip to content

Commit 00cb53b

Browse files
authored
fix: bugfix for LuminaReader in NormalizeSearchOptions process (#112)
1 parent 00fd06d commit 00cb53b

4 files changed

Lines changed: 6 additions & 15 deletions

File tree

src/paimon/global_index/lumina/lumina_global_index.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -345,7 +345,7 @@ Result<std::shared_ptr<VectorSearchGlobalIndexResult>> LuminaIndexReader::VisitV
345345
lumina_options[std::string(::lumina::core::kSearchThreadSafeFilter)] = "true";
346346
PAIMON_ASSIGN_OR_RAISE_FROM_LUMINA(
347347
::lumina::api::SearchOptions search_options,
348-
::lumina::api::NormalizeSearchOptions(std::string(::lumina::core::kIndexType),
348+
::lumina::api::NormalizeSearchOptions(index_info_.index_type,
349349
std::unordered_map<std::string, std::string>(
350350
lumina_options.begin(), lumina_options.end())));
351351

third_party/lumina/include/lumina/core/Constants.h

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,9 @@ constexpr uint32_t LUMINA_CURRENT_VERSION = 0;
2525
// Prime magic number
2626
constexpr uint32_t LUMINA_MAGIC_NUMBER = 19260817u;
2727

28+
// Recommended file suffix for Lumina persisted artifacts (not enforced by IO).
29+
constexpr std::string_view kLuminaFileSuffix = ".lmi";
30+
2831
// Basic options
2932
constexpr std::string_view kIndexPrefix = "index.";
3033
constexpr std::string_view kDimension = "index.dimension";

third_party/lumina/include/lumina/core/ErrorCodes.h

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -45,16 +45,4 @@ enum class ErrorCode : int32_t {
4545

4646
constexpr int32_t ToInt(ErrorCode c) noexcept { return static_cast<int32_t>(c); }
4747

48-
constexpr bool IsRetryable(ErrorCode c) noexcept
49-
{
50-
switch (c) {
51-
case ErrorCode::Unavailable:
52-
case ErrorCode::Timeout:
53-
case ErrorCode::ResourceExhausted:
54-
return true;
55-
default:
56-
return false;
57-
}
58-
}
59-
6048
}} // namespace lumina::core::v1
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
version https://git-lfs.github.com/spec/v1
2-
oid sha256:270b08a7bd84b047a00f3157c98829fa3941407c83121c50894bec26d56c79b6
3-
size 64267408
2+
oid sha256:96a3daac23d796f5e1c48f719af54bc20f1ddaeecfe85aa86dcebdfd4415c41f
3+
size 64125448

0 commit comments

Comments
 (0)